Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read system parameters that exist in config #18486

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Conversation

bill-rich
Copy link
Contributor

The current behavior is to only read user parameters. If a system parameteris set in the configuration, the plan will result in a diff every time because the system parameters are never read. This changes the behavior to read all parameters, and read user parameters and any parameters that exist in the configuration.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13384

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDocDBClusterParameterGroup_ -timeout 180m
=== RUN   TestAccAWSDocDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDocDBClusterParameterGroup_basic
=== RUN   TestAccAWSDocDBClusterParameterGroup_systemParameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_systemParameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDocDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDocDBClusterParameterGroup_Description
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Description
=== RUN   TestAccAWSDocDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDocDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_Parameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Parameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_Tags
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_basic
=== CONT  TestAccAWSDocDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDocDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDocDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_Description
=== CONT  TestAccAWSDocDBClusterParameterGroup_Parameter
=== CONT  TestAccAWSDocDBClusterParameterGroup_systemParameter
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (12.65s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (15.72s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_systemParameter (16.03s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (17.40s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (26.79s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (27.98s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (28.92s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (39.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.318s

@bill-rich bill-rich requested a review from a team as a code owner March 30, 2021 17:40
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 30, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always test import when possible. 👍

aws/structure.go Outdated Show resolved Hide resolved
aws/structure.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 1, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (13.01s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (18.42s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (18.46s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (18.64s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_systemParameter (18.65s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (18.72s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (29.02s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (39.63s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (17.30s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (23.65s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (23.68s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (24.10s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (24.10s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_systemParameter (24.14s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (38.56s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (53.12s)

@bill-rich bill-rich merged commit e6fae9a into main Apr 5, 2021
@bill-rich bill-rich deleted the b-read_system_parameters branch April 5, 2021 16:18
@github-actions github-actions bot added this to the v3.36.0 milestone Apr 5, 2021
github-actions bot pushed a commit that referenced this pull request Apr 5, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/docdb Issues and PRs that pertain to the docdb service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform apply always shows changes on documentdb parameter group
2 participants