Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ecr_replication - delete rules on resource delete #18882

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18708

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrReplicationConfiguration_basic'
--- PASS: TestAccAWSEcrReplicationConfiguration_basic (40.75s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner April 15, 2021 11:14
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Apr 15, 2021
@anGie44 anGie44 self-assigned this Apr 15, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @DrFaust92 , LGTM 🚀

Output of acceptance test:

--- PASS: TestAccAWSEcrReplicationConfiguration_basic (15.48s)

@anGie44 anGie44 added this to the v3.37.0 milestone Apr 16, 2021
@anGie44 anGie44 merged commit e7d6715 into hashicorp:main Apr 16, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
@DrFaust92 DrFaust92 deleted the r/ecr_replication_delete_rules branch May 16, 2021 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecr Issues and PRs that pertain to the ecr service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroying aws_ecr_replication_configuration resource leaves replication enabled
2 participants