Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: add additional if-condition when setting tags_all to new computed #19251

Merged
merged 1 commit into from
May 6, 2021
Merged

provider: add additional if-condition when setting tags_all to new computed #19251

merged 1 commit into from
May 6, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 5, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18366

Notes

  • Provider produced inconsistent final plan - tags_all errors without using default_tags block #18366 (comment) revealed that in cases where resource tags are dynamic (e.g. using timestamp()) and the lifecycle ignore_changes is applied, the SetTagsDiff CustomizeDiff does not correctly set the tags_all attribute to new Computed as expected, but rather tries to remove all previous values by setting them to null since the result of len(diff.Get("tags_all").(map[string]interface{})) is 0.
  • To handle this, an additional condition is in place to look just for a change in tags_all

Output from acceptance testing (2 new tests created to showcase behavior in #18366 (comment) before code change):

=== CONT  TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
    resource_aws_vpc_test.go:507: Step 2/2 error: Error running apply: exit status 1

        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_vpc.test to include new values learned so far
        during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "created_at" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_vpc.test to include new values learned so far
        during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "updated_at" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

=== CONT  TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
    resource_aws_vpc_test.go:451: Step 2/2 error: Error running apply: exit status 1

        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_vpc.test to include new values learned so far
        during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "created_at" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_vpc.test to include new values learned so far
        during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "localkey" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_vpc.test to include new values learned so far
        during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "updated_at" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

Output from acceptance testing (after code change):


--- PASS: TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges (149.66s)
--- PASS: TestAccAWSVpc_DynamicResourceTags_IgnoreChanges (157.73s)

--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (184.34s)
--- PASS: TestAccAWSProvider_Region_AwsC2S (184.66s)
--- PASS: TestAccAWSProvider_Region_AwsChina (184.91s)
--- PASS: TestAccAWSProvider_Region_AwsSC2S (184.97s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (185.36s)
--- PASS: TestAccAWSProvider_DefaultTags_Tags_One (189.87s)
--- PASS: TestAccAWSProvider_DefaultTags_Tags_Multiple (190.05s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (190.26s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (190.28s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (190.28s)
--- PASS: TestAccAWSProvider_DefaultTags_Tags_None (190.28s)
--- PASS: TestAccAWSProvider_DefaultTags_EmptyConfigurationBlock (190.36s)
--- PASS: TestAccAWSProvider_DefaultAndIgnoreTags_EmptyConfigurationBlocks (190.46s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (190.46s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (190.46s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (190.47s)
--- PASS: TestAccAWSProvider_Endpoints (190.47s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (190.75s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (211.21s)

--- PASS: TestAccAWSVpc_coreMismatchedDiffs (91.47s)
--- PASS: TestAccAWSVpc_disappears (93.96s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (99.73s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (110.61s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (121.47s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (121.76s)
--- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (149.23s)
--- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (150.30s)
--- PASS: TestAccAWSVpc_basic (143.80s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (170.79s)
--- PASS: TestAccAWSVpc_defaultAndIgnoreTags (172.16s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (181.99s)
--- PASS: TestAccAWSVpc_ignoreTags (184.20s)
--- PASS: TestAccAWSVpc_defaultTags_providerOnly (186.45s)
--- PASS: TestAccAWSVpc_update (186.67s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (212.00s)
--- PASS: TestAccAWSVpc_tags (214.55s)
--- PASS: TestAccAWSVpc_Tenancy (216.03s)

--- SKIP: TestAccAWSSubnet_CustomerOwnedIpv4Pool (5.42s)
--- SKIP: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (5.50s)
--- SKIP: TestAccAWSSubnet_outpost (5.71s)
--- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_duplicateTag (6.43s)
--- PASS: TestAccAWSSubnet_disappears (96.41s)
--- PASS: TestAccAWSSubnet_basic (112.04s)
--- PASS: TestAccAWSSubnet_availabilityZoneId (120.06s)
--- PASS: TestAccAWSSubnet_defaultTags_updateToResourceOnly (171.81s)
--- PASS: TestAccAWSSubnet_defaultTags_updateToProviderOnly (173.02s)
--- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_nonOverlappingTag (185.60s)
--- PASS: TestAccAWSSubnet_ignoreTags (188.70s)
--- PASS: TestAccAWSSubnet_defaultAndIgnoreTags (193.26s)
--- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_overlappingTag (195.20s)
--- PASS: TestAccAWSSubnet_defaultTags_providerOnly (198.85s)
--- PASS: TestAccAWSSubnet_tags (203.89s)
--- PASS: TestAccAWSSubnet_updateTagsKnownAtApply (205.46s)
--- PASS: TestAccAWSSubnet_enableIpv6 (206.40s)
--- PASS: TestAccAWSSubnet_MapPublicIpOnLaunch (215.81s)
--- PASS: TestAccAWSSubnet_ipv6 (221.08s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 5, 2021
@anGie44 anGie44 changed the title provider: add additional if-condition when setting tags_all to new computed provider: add additional if-condition when setting tags_all to new computed May 5, 2021
@anGie44 anGie44 force-pushed the b-tags-all-ignore-changes-inconsistent-final-plan branch 2 times, most recently from 11ed876 to 919fc83 Compare May 5, 2021 20:09
@anGie44 anGie44 marked this pull request as ready for review May 5, 2021 20:22
@anGie44 anGie44 requested a review from a team as a code owner May 5, 2021 20:22
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label May 5, 2021
@anGie44 anGie44 force-pushed the b-tags-all-ignore-changes-inconsistent-final-plan branch from 24a4577 to bd40159 Compare May 5, 2021 20:44
@anGie44 anGie44 force-pushed the b-tags-all-ignore-changes-inconsistent-final-plan branch from bd40159 to 7d7dce3 Compare May 5, 2021 20:44
ewbankkit
ewbankkit approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc_' ACCTEST_PARALLELISM=10
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSVpc_ -timeout 180m
=== RUN   TestAccAWSVpc_coreMismatchedDiffs
=== PAUSE TestAccAWSVpc_coreMismatchedDiffs
=== RUN   TestAccAWSVpc_basic
=== PAUSE TestAccAWSVpc_basic
=== RUN   TestAccAWSVpc_disappears
=== PAUSE TestAccAWSVpc_disappears
=== RUN   TestAccAWSVpc_defaultTags_providerOnly
=== PAUSE TestAccAWSVpc_defaultTags_providerOnly
=== RUN   TestAccAWSVpc_defaultTags_updateToProviderOnly
=== PAUSE TestAccAWSVpc_defaultTags_updateToProviderOnly
=== RUN   TestAccAWSVpc_defaultTags_updateToResourceOnly
=== PAUSE TestAccAWSVpc_defaultTags_updateToResourceOnly
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
=== RUN   TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
=== PAUSE TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
=== RUN   TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
=== PAUSE TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
=== RUN   TestAccAWSVpc_defaultAndIgnoreTags
=== PAUSE TestAccAWSVpc_defaultAndIgnoreTags
=== RUN   TestAccAWSVpc_ignoreTags
=== PAUSE TestAccAWSVpc_ignoreTags
=== RUN   TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== PAUSE TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== RUN   TestAccAWSVpc_Tenancy
=== PAUSE TestAccAWSVpc_Tenancy
=== RUN   TestAccAWSVpc_tags
=== PAUSE TestAccAWSVpc_tags
=== RUN   TestAccAWSVpc_update
=== PAUSE TestAccAWSVpc_update
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
=== PAUSE TestAccAWSVpc_bothDnsOptionsSet
=== RUN   TestAccAWSVpc_DisabledDnsSupport
=== PAUSE TestAccAWSVpc_DisabledDnsSupport
=== RUN   TestAccAWSVpc_classiclinkOptionSet
=== PAUSE TestAccAWSVpc_classiclinkOptionSet
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== PAUSE TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_coreMismatchedDiffs
=== CONT  TestAccAWSVpc_defaultAndIgnoreTags
=== CONT  TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== CONT  TestAccAWSVpc_update
=== CONT  TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_classiclinkOptionSet
=== CONT  TestAccAWSVpc_DisabledDnsSupport
=== CONT  TestAccAWSVpc_bothDnsOptionsSet
=== CONT  TestAccAWSVpc_Tenancy
=== CONT  TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (28.37s)
=== CONT  TestAccAWSVpc_ignoreTags
--- PASS: TestAccAWSVpc_classiclinkOptionSet (34.26s)
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (34.43s)
=== CONT  TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (42.58s)
=== CONT  TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
--- PASS: TestAccAWSVpc_DisabledDnsSupport (42.72s)
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag (2.17s)
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
--- PASS: TestAccAWSVpc_defaultAndIgnoreTags (56.70s)
=== CONT  TestAccAWSVpc_defaultTags_providerOnly
--- PASS: TestAccAWSVpc_update (60.53s)
=== CONT  TestAccAWSVpc_defaultTags_updateToResourceOnly
--- PASS: TestAccAWSVpc_DynamicResourceTags_IgnoreChanges (41.44s)
=== CONT  TestAccAWSVpc_defaultTags_updateToProviderOnly
--- PASS: TestAccAWSVpc_tags (76.01s)
=== CONT  TestAccAWSVpc_disappears
--- PASS: TestAccAWSVpc_ignoreTags (49.21s)
=== CONT  TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (79.19s)
--- PASS: TestAccAWSVpc_Tenancy (80.40s)
--- PASS: TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges (42.79s)
--- PASS: TestAccAWSVpc_disappears (14.63s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (56.53s)
--- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (37.30s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (57.26s)
--- PASS: TestAccAWSVpc_basic (24.72s)
--- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (35.16s)
--- PASS: TestAccAWSVpc_defaultTags_providerOnly (55.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	116.036s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpc_ -timeout 180m
=== RUN   TestAccAWSVpc_coreMismatchedDiffs
=== PAUSE TestAccAWSVpc_coreMismatchedDiffs
=== RUN   TestAccAWSVpc_basic
=== PAUSE TestAccAWSVpc_basic
=== RUN   TestAccAWSVpc_disappears
=== PAUSE TestAccAWSVpc_disappears
=== RUN   TestAccAWSVpc_defaultTags_providerOnly
=== PAUSE TestAccAWSVpc_defaultTags_providerOnly
=== RUN   TestAccAWSVpc_defaultTags_updateToProviderOnly
=== PAUSE TestAccAWSVpc_defaultTags_updateToProviderOnly
=== RUN   TestAccAWSVpc_defaultTags_updateToResourceOnly
=== PAUSE TestAccAWSVpc_defaultTags_updateToResourceOnly
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
=== RUN   TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
=== PAUSE TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
=== RUN   TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
=== PAUSE TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
=== RUN   TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
=== PAUSE TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
=== RUN   TestAccAWSVpc_defaultAndIgnoreTags
=== PAUSE TestAccAWSVpc_defaultAndIgnoreTags
=== RUN   TestAccAWSVpc_ignoreTags
=== PAUSE TestAccAWSVpc_ignoreTags
=== RUN   TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== PAUSE TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== RUN   TestAccAWSVpc_Tenancy
=== PAUSE TestAccAWSVpc_Tenancy
=== RUN   TestAccAWSVpc_tags
=== PAUSE TestAccAWSVpc_tags
=== RUN   TestAccAWSVpc_update
=== PAUSE TestAccAWSVpc_update
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
=== PAUSE TestAccAWSVpc_bothDnsOptionsSet
=== RUN   TestAccAWSVpc_DisabledDnsSupport
=== PAUSE TestAccAWSVpc_DisabledDnsSupport
=== RUN   TestAccAWSVpc_classiclinkOptionSet
=== PAUSE TestAccAWSVpc_classiclinkOptionSet
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== PAUSE TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_coreMismatchedDiffs
=== CONT  TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_update
=== CONT  TestAccAWSVpc_defaultAndIgnoreTags
=== CONT  TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== CONT  TestAccAWSVpc_tags
=== CONT  TestAccAWSVpc_Tenancy
=== CONT  TestAccAWSVpc_classiclinkOptionSet
=== CONT  TestAccAWSVpc_DisabledDnsSupport
=== CONT  TestAccAWSVpc_bothDnsOptionsSet
=== CONT  TestAccAWSVpc_defaultTags_providerOnly
=== CONT  TestAccAWSVpc_defaultTags_updateToResourceOnly
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag
=== CONT  TestAccAWSVpc_basic
=== CONT  TestAccAWSVpc_defaultTags_updateToProviderOnly
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag
=== CONT  TestAccAWSVpc_ignoreTags
=== CONT  TestAccAWSVpc_DynamicResourceTags_IgnoreChanges
=== CONT  TestAccAWSVpc_disappears
=== CONT  TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag (15.79s)
=== CONT  TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges
=== CONT  TestAccAWSVpc_classiclinkDnsSupportOptionSet
    provider_test.go:1115: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/06 17:12:50 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: error enabling VPC (vpc-027c6daf549f37bef) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: 7855f982-0ae9-43e0-8483-f11e1d67cdab
        
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
        
=== CONT  TestAccAWSVpc_classiclinkOptionSet
    provider_test.go:1115: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/06 17:12:50 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: error enabling VPC (vpc-08f739a943476cbc3) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: 133dfb23-4a99-4055-988d-7e9517aa6adb
        
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
        
--- SKIP: TestAccAWSVpc_classiclinkDnsSupportOptionSet (21.73s)
--- SKIP: TestAccAWSVpc_classiclinkOptionSet (21.78s)
--- PASS: TestAccAWSVpc_disappears (37.60s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (45.42s)
--- PASS: TestAccAWSVpc_basic (52.51s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (57.30s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (57.75s)
--- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (61.17s)
--- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (69.42s)
--- PASS: TestAccAWSVpc_DynamicResourceTags_IgnoreChanges (72.42s)
--- PASS: TestAccAWSVpc_DynamicResourceTagsMergedWithLocals_IgnoreChanges (58.66s)
--- PASS: TestAccAWSVpc_defaultAndIgnoreTags (79.22s)
--- PASS: TestAccAWSVpc_ignoreTags (82.81s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (83.20s)
--- PASS: TestAccAWSVpc_defaultTags_providerOnly (85.34s)
--- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (85.32s)
--- PASS: TestAccAWSVpc_update (85.29s)
--- PASS: TestAccAWSVpc_tags (107.71s)
--- PASS: TestAccAWSVpc_Tenancy (108.01s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (108.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	113.503s

@gdavison gdavison merged commit cfa149d into main May 6, 2021
@gdavison gdavison deleted the b-tags-all-ignore-changes-inconsistent-final-plan branch May 6, 2021 23:09
@github-actions github-actions bot added this to the v3.39.0 milestone May 6, 2021
github-actions bot pushed a commit that referenced this pull request May 6, 2021
Update CHANGELOG.md for #19251
aeb3291
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.39.0
Development

Successfully merging this pull request may close these issues.

Provider produced inconsistent final plan - tags_all errors without using default_tags block
3 participants
@anGie44 @ewbankkit @gdavison