Add encrypted SES SMTP password

[bartoszj]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Encrypt SES SMTP password like IAM secret, by using PGP/KeyBase.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAccessKey'                                                                                                                                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAccessKey -timeout 180m
=== RUN   TestAccAWSAccessKey_basic
=== PAUSE TestAccAWSAccessKey_basic
=== RUN   TestAccAWSAccessKey_encrypted
=== PAUSE TestAccAWSAccessKey_encrypted
=== RUN   TestAccAWSAccessKey_Status
=== PAUSE TestAccAWSAccessKey_Status
=== CONT  TestAccAWSAccessKey_basic
=== CONT  TestAccAWSAccessKey_Status
=== CONT  TestAccAWSAccessKey_encrypted
--- PASS: TestAccAWSAccessKey_encrypted (45.29s)
--- PASS: TestAccAWSAccessKey_basic (46.11s)
--- PASS: TestAccAWSAccessKey_Status (82.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.036s

[github-actions]

Welcome @bartoszj 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[gupta-aayush]

Thanks @bartoszj for adding these changes. It will surely help in generating SMTP credentials through terraform with encryption. I would request hashicorp team to approve this PR asap.

[YakDriver]

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSAccessKey_basic (13.31s)
--- PASS: TestAccAWSAccessKey_encrypted (13.38s)
--- PASS: TestAccAWSAccessKey_status (28.23s)
--- PASS: TestSesSmtpPasswordFromSecretKeySigV4 (0.00s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAWSAccessKey_basic (18.52s)
--- PASS: TestAccAWSAccessKey_encrypted (18.63s)
--- PASS: TestAccAWSAccessKey_status (42.65s)
--- PASS: TestSesSmtpPasswordFromSecretKeySigV4 (0.00s)

[github-actions]

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.