Make Redshift parameters case sensitive

[saraogivinay]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

vinaysaraogi@flashtime:~/vena/github/terraform-provider-aws$ make testacc TESTARGS='-run=TestAccAWSRedshiftParameterGroup_withParameters'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRedshiftParameterGroup_withParameters -timeout 180m
=== RUN   TestAccAWSRedshiftParameterGroup_withParameters
=== PAUSE TestAccAWSRedshiftParameterGroup_withParameters
=== CONT  TestAccAWSRedshiftParameterGroup_withParameters
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (12.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.477s

Context:

Some of the Redshift parameters are case sensitive. AWS API returns Uppercase values for some of its parameters such as datestyle which takes values such as ISO, MDY. Because the aws terraform provide lowercases all parameters, terraform always shows a change for the parameters with case difference.

[github-actions]

Welcome @saraogivinay 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bill-rich]

Looks good. Thanks for the contribution!

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRedshiftParameterGroup_ -timeout 180m
=== RUN   TestAccAWSRedshiftParameterGroup_basic
=== PAUSE TestAccAWSRedshiftParameterGroup_basic
=== RUN   TestAccAWSRedshiftParameterGroup_withParameters
=== PAUSE TestAccAWSRedshiftParameterGroup_withParameters
=== RUN   TestAccAWSRedshiftParameterGroup_withoutParameters
=== PAUSE TestAccAWSRedshiftParameterGroup_withoutParameters
=== RUN   TestAccAWSRedshiftParameterGroup_withTags
=== PAUSE TestAccAWSRedshiftParameterGroup_withTags
=== CONT  TestAccAWSRedshiftParameterGroup_basic
=== CONT  TestAccAWSRedshiftParameterGroup_withoutParameters
=== CONT  TestAccAWSRedshiftParameterGroup_withParameters
=== CONT  TestAccAWSRedshiftParameterGroup_withTags
--- PASS: TestAccAWSRedshiftParameterGroup_basic (16.41s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (16.42s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (16.42s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (37.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.099s

[github-actions]

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.