Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/elasticache_replication_group: deprecations/addition of args to align with API #22666

Merged
merged 3 commits into from
Feb 2, 2022
Merged

r/elasticache_replication_group: deprecations/addition of args to align with API #22666

merged 3 commits into from
Feb 2, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 19, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18440

Output from acceptance testing:

--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (2895.64s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (3412.37s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (2444.71s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (3785.57s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (2259.96s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (1284.76s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (986.34s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (2407.81s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (4297.71s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1119.46s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (3564.32s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2326.51s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (2346.31s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3332.60s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverDisabled (1769.28s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverEnabled (1724.35s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1297.06s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (1826.56s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (1786.72s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (2260.38s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1712.56s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (2057.71s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (16.64s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (994.98s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (5.78s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (1265.41s)
--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (1.93s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (657.04s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (604.91s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (716.55s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (1202.86s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (1771.62s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1065.53s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (1227.82s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (2913.70s)
--- PASS: TestAccElastiCacheReplicationGroup_redisClusterInVPC2 (1631.10s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (1402.61s)
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (940.81s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (1104.66s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (1346.08s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1555.67s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (1943.29s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (2123.66s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (1161.08s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (1813.47s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. labels Jan 19, 2022
anGie44 added a commit that referenced this pull request Jan 19, 2022
@anGie44
Update CHANGELOG for #22666
4af00e1
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. labels Jan 19, 2022
@anGie44 anGie44 requested a review from gdavison January 19, 2022 21:08
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 19, 2022
@anGie44 anGie44 force-pushed the f-deprecate-elasticache-replication-resource-args branch 2 times, most recently from 6d9fdf5 to c3554e6 Compare January 19, 2022 22:12
@anGie44 anGie44 marked this pull request as ready for review January 20, 2022 00:44
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 20, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 4 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 7 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22666
fe75ebd
@anGie44 anGie44 force-pushed the f-deprecate-elasticache-replication-resource-args branch from c3554e6 to 2ed3d97 Compare January 28, 2022 22:49
Base automatically changed from release/4.x to main January 31, 2022 22:59
@anGie44 anGie44 force-pushed the f-deprecate-elasticache-replication-resource-args branch from 8612463 to 8defc76 Compare February 1, 2022 00:19
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. service/inspector Issues and PRs that pertain to the inspector service. sweeper Pertains to changes to or issues with the sweeper. service/cloudwatchlogs service/efs Issues and PRs that pertain to the efs service. service/emr Issues and PRs that pertain to the emr service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. service/eks Issues and PRs that pertain to the eks service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. labels Feb 1, 2022
@anGie44 anGie44 force-pushed the f-deprecate-elasticache-replication-resource-args branch from 8defc76 to ef0953b Compare February 1, 2022 00:20
@gdavison gdavison self-assigned this Feb 2, 2022
gdavison
gdavison approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (52.07s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (749.29s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (811.90s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (1030.32s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (1197.37s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_basic (1201.42s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (1372.07s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (701.25s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (1532.89s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1542.62s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (1581.12s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1581.70s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1640.91s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (2.67s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (1698.91s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (965.06s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (2113.43s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (2305.39s)
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (1366.34s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverDisabled (2478.61s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (1081.69s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverEnabled (2687.56s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (2713.37s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (684.17s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2827.86s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1330.12s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (1155.91s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_nonExistent (2.50s)
--- PASS: TestAccElastiCacheReplicationGroup_redisClusterInVPC2 (1355.62s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (1884.57s)
--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (2.20s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (946.60s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (878.18s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (823.69s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (1027.31s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (2009.96s)
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1253.11s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3737.50s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (2386.25s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_multiAZ (1028.74s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (2751.85s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (1278.83s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_clusterMode (1120.78s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (1148.59s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (2583.87s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1894.33s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (3295.21s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (3587.95s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (5183.63s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (3430.56s)

@anGie44 anGie44 merged commit bb56afd into main Feb 2, 2022
@anGie44 anGie44 deleted the f-deprecate-elasticache-replication-resource-args branch February 2, 2022 17:29
@anGie44 anGie44 mentioned this pull request Feb 2, 2022
Closed
@gdavison gdavison mentioned this pull request Feb 3, 2022
Merged
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @gdavison