Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_drs_replication_configuration_template #26399

Merged
merged 28 commits into from
Jun 18, 2024

Conversation

lewinkedrs
Copy link
Contributor

@lewinkedrs lewinkedrs commented Aug 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21865
Relates #37816

Output from acceptance testing:

Need assistance/guidance in creating an acceptance test for the new resource. I was hoping for some community help/support in creating the test.

Current Status (4 June 2024): ~90% there

@lewinkedrs Thank you for your work on this! I have reworked your PR significantly so make sure to pull your branch if you happen to work on it again.

  • Convert to AWS SDK v2
  • Convert to Framework
  • Get basic acceptance test working (current error: Invalid request body)
  • Add disappears test
  • Docs: Add timeouts and import sections
  • Docs: Revise formatting to standard
  • Docs: "Basic configuration" is not in TF standard format
  • Docs: Add valid values (currently listed in example)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/drs Issues and PRs that pertain to the drs service. size/XL Managed by automation to categorize the size of a PR. labels Aug 19, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 19, 2022
@lewinkedrs
Copy link
Contributor Author

I had been using the git hub actions to fix formatting issues and one of them said to run #make gen and then commit. I did this and now there are merge conflicts due to the .semgrep-service-name.yml files since DRS is a new service. What is the proper path forward here? Revert that commit?

@k-brooks
Copy link

Bump - would like to see this completed, could anyone detail what work remains?

@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
@YakDriver YakDriver self-assigned this Jun 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 3, 2024
@YakDriver YakDriver mentioned this pull request Jun 3, 2024
@YakDriver YakDriver force-pushed the drs-replication-configuration branch 2 times, most recently from d2f8cb9 to 36d1f0c Compare June 4, 2024 23:15
@YakDriver YakDriver changed the title Drs replication configuration [feature] New resource: aws_drs_replication_configuration_template Jun 4, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. labels Jun 4, 2024
@YakDriver
Copy link
Member

@k-brooks Thanks for your interest! Please see the op.

@YakDriver YakDriver changed the title [feature] New resource: aws_drs_replication_configuration_template New resource: aws_drs_replication_configuration_template Jun 4, 2024
@YakDriver YakDriver force-pushed the drs-replication-configuration branch from a77d447 to df1acae Compare June 18, 2024 20:25
@YakDriver YakDriver requested a review from a team as a code owner June 18, 2024 20:25
@YakDriver
Copy link
Member

Unfortunately, additional resources or functionality may be needed before this is useful. This is a best-effort first step.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@YakDriver YakDriver merged commit a7ea653 into hashicorp:main Jun 18, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 18, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 20, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/drs Issues and PRs that pertain to the drs service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New resource: aws_drs_replication_configuration_template AWS Elastic Disaster Recovery Service
4 participants