Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc): Enable addition amazon provided ipv6 cidr #27274

Merged

Conversation

project0
Copy link
Contributor

  • Extend existing vpc_ipv6_cidr_block_association resource to allow requesting additional ipv6 CIDR from the amazon pool

Description

Relations

Closes #25136

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AssociateVpcCidrBlock.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Oct 17, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @project0 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@project0 project0 force-pushed the feat/ipv6-associate-amazon-provided-pool branch from e34f8f2 to 377212d Compare October 18, 2022 13:44
* Extend existing `vpc_ipv6_cidr_block_association` resource to allow
  requesting additional ipv6 CIDR from the amazon pool
@project0 project0 force-pushed the feat/ipv6-associate-amazon-provided-pool branch from 377212d to 56dea14 Compare October 18, 2022 13:51
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 21, 2022
@posquit0
Copy link
Contributor

Currently, there are some limitations to manage VPC's IPv6 CIDR. I hope that this feature will be implemented quickly.

@nikosmeds
Copy link

What can we do to get movement here? 🙏

@ewbankkit ewbankkit self-assigned this Jul 26, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner July 26, 2024 18:32
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCIPv6CIDRBlockAssociation_basic\|TestAccVPCIPv6CIDRBlockAssociation_disappears' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCIPv6CIDRBlockAssociation_basic\|TestAccVPCIPv6CIDRBlockAssociation_disappears -timeout 360m
=== RUN   TestAccVPCIPv6CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv6CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv6CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv6CIDRBlockAssociation_disappears
=== CONT  TestAccVPCIPv6CIDRBlockAssociation_basic
=== CONT  TestAccVPCIPv6CIDRBlockAssociation_disappears
--- PASS: TestAccVPCIPv6CIDRBlockAssociation_basic (51.13s)
--- PASS: TestAccVPCIPv6CIDRBlockAssociation_disappears (57.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	62.522s

@ewbankkit
Copy link
Contributor

@project0 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 528314a into hashicorp:main Jul 26, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 26, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_vpc_ipv6_cidr_block_association only accepts IPAM pool
5 participants