Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source]: aws_batch_job_definition #28665

Closed
iancward opened this issue Jan 4, 2023 · 4 comments · Fixed by #34663
Closed

[New Data Source]: aws_batch_job_definition #28665

iancward opened this issue Jan 4, 2023 · 4 comments · Fixed by #34663
Assignees
Labels
new-data-source Introduces a new data source. service/batch Issues and PRs that pertain to the batch service.
Milestone

Comments

@iancward
Copy link
Contributor

iancward commented Jan 4, 2023

Description

I have a project that creates resources in AWS Batch (job queues, job definitions, compute environments), and a separate project that consumes those resources. While I understand that I can rely on Terraform Remote State to convey information from one project to another, in this case I'd like to avoid that and would prefer to use discrete data lookups in the downstream project.

Since Batch Job Definitions support multiple revisions, I would presume by default the data source should retrieve the latest revision.

Requested Resource(s) and/or Data Source(s)

  • data.aws_batch_job_definition

Potential Terraform Configuration

data "aws_batch_job_definition" "main" {
  name = "my-job-definition"
}

data "aws_batch_job_queue" "main" {
  name = "my-job-queue"
}

locals {
  job_def_arn_less_revision = regex("^(.*)(:\\d+)$", data.aws_batch_job_definition.main.arn)
}

data "aws_iam_policy_document" "batch_execute" {
  statement {
    sid       = "AllowBatchExecute"
    actions   = ["batch:SubmitJob"]
    effect    = "allow"
    resources = [
      local.job_def_arn_less_revision,
      data.aws_batch_job_queue.main.arn
    ]
  }
}

References

No response

Would you like to implement a fix?

None

@iancward iancward added the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2023
@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. service/iam Issues and PRs that pertain to the iam service. labels Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. labels Jan 4, 2023
@drewmullen drewmullen self-assigned this Nov 3, 2023
@drewmullen
Copy link
Collaborator

drewmullen commented Nov 3, 2023

proposed HCL

data "aws_batch_job_definition" "main" {
  name   = "my-job-definition"
  status = "ACTIVE"
  latest = true

  #optional, coflicting:
  revision = <int>
}

3 ways of finding a specific job.

  • setting status and latest
  • specifying a revision
  • arn

Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants