New data source aws_quicksight_analysis

[comtef]

Description

• New data source for Quicksight Analysis.
• Fixed typos and missing fields on existing schemas shared with Template/Analysis/Dashboard resources.
• Moved resource to data source schema helper to shared package internal/schema (same naming convention as internal/service/quicksight/schema)

Relations

Closes #31736.
Closes #33524.
Closes #33616.
Closes #33617.

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysis.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysisDefinition.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysisPermissions.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccQuickSightAnalysisDataSource PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysisDataSource'  -timeout 180m
=== RUN   TestAccQuickSightAnalysisDataSource_basic
=== PAUSE TestAccQuickSightAnalysisDataSource_basic
=== CONT  TestAccQuickSightAnalysisDataSource_basic
--- PASS: TestAccQuickSightAnalysisDataSource_basic (57.99s)
PASS

$ make testacc TESTS=TestAccQuickSightAnalysis PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis'  -timeout 180m
=== RUN   TestAccQuickSightAnalysisDataSource_basic
=== PAUSE TestAccQuickSightAnalysisDataSource_basic
=== RUN   TestAccQuickSightAnalysis_basic
=== PAUSE TestAccQuickSightAnalysis_basic
=== RUN   TestAccQuickSightAnalysis_disappears
=== PAUSE TestAccQuickSightAnalysis_disappears
=== RUN   TestAccQuickSightAnalysis_sourceEntity
=== PAUSE TestAccQuickSightAnalysis_sourceEntity
=== RUN   TestAccQuickSightAnalysis_update
=== PAUSE TestAccQuickSightAnalysis_update
=== RUN   TestAccQuickSightAnalysis_parametersConfig
=== PAUSE TestAccQuickSightAnalysis_parametersConfig
=== RUN   TestAccQuickSightAnalysis_forceDelete
=== PAUSE TestAccQuickSightAnalysis_forceDelete
=== RUN   TestAccQuickSightAnalysis_theme
=== PAUSE TestAccQuickSightAnalysis_theme
=== CONT  TestAccQuickSightAnalysisDataSource_basic
=== CONT  TestAccQuickSightAnalysis_theme
=== CONT  TestAccQuickSightAnalysis_forceDelete
=== CONT  TestAccQuickSightAnalysis_parametersConfig
=== CONT  TestAccQuickSightAnalysis_update
=== CONT  TestAccQuickSightAnalysis_sourceEntity
=== CONT  TestAccQuickSightAnalysis_disappears
=== CONT  TestAccQuickSightAnalysis_basic
--- PASS: TestAccQuickSightAnalysis_forceDelete (115.51s)
--- PASS: TestAccQuickSightAnalysis_disappears (117.47s)
--- PASS: TestAccQuickSightAnalysisDataSource_basic (129.53s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (132.69s)
--- PASS: TestAccQuickSightAnalysis_theme (137.87s)
--- PASS: TestAccQuickSightAnalysis_basic (139.10s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (144.47s)
--- PASS: TestAccQuickSightAnalysis_update (181.54s)
PASS

$ make testacc TESTS=TestAccQuickSightDashboard PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDashboard'  -timeout 180m
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== RUN   TestAccQuickSightDashboard_theme
=== PAUSE TestAccQuickSightDashboard_theme
=== CONT  TestAccQuickSightDashboard_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightDashboard_sourceEntity
=== CONT  TestAccQuickSightDashboard_theme
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_disappears
--- PASS: TestAccQuickSightDashboard_disappears (100.89s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (105.90s)
--- PASS: TestAccQuickSightDashboard_theme (113.12s)
--- PASS: TestAccQuickSightDashboard_basic (116.54s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (121.17s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (156.53s)
PASS

$ make testacc TESTS=TestAccQuickSightTemplate PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTemplate'  -timeout 180m
=== RUN   TestAccQuickSightTemplateAlias_basic
=== PAUSE TestAccQuickSightTemplateAlias_basic
=== RUN   TestAccQuickSightTemplateAlias_disappears
=== PAUSE TestAccQuickSightTemplateAlias_disappears
=== RUN   TestAccQuickSightTemplate_basic
=== PAUSE TestAccQuickSightTemplate_basic
=== RUN   TestAccQuickSightTemplate_disappears
=== PAUSE TestAccQuickSightTemplate_disappears
=== RUN   TestAccQuickSightTemplate_barChart
=== PAUSE TestAccQuickSightTemplate_barChart
=== RUN   TestAccQuickSightTemplate_table
=== PAUSE TestAccQuickSightTemplate_table
=== RUN   TestAccQuickSightTemplate_sourceEntity
=== PAUSE TestAccQuickSightTemplate_sourceEntity
=== RUN   TestAccQuickSightTemplate_tags
=== PAUSE TestAccQuickSightTemplate_tags
=== RUN   TestAccQuickSightTemplate_update
=== PAUSE TestAccQuickSightTemplate_update
=== CONT  TestAccQuickSightTemplateAlias_basic
=== CONT  TestAccQuickSightTemplate_table
=== CONT  TestAccQuickSightTemplate_update
=== CONT  TestAccQuickSightTemplate_tags
=== CONT  TestAccQuickSightTemplate_sourceEntity
=== CONT  TestAccQuickSightTemplate_disappears
=== CONT  TestAccQuickSightTemplate_barChart
=== CONT  TestAccQuickSightTemplate_basic
=== CONT  TestAccQuickSightTemplateAlias_disappears
--- PASS: TestAccQuickSightTemplate_disappears (116.74s)
--- PASS: TestAccQuickSightTemplateAlias_disappears (124.18s)
--- PASS: TestAccQuickSightTemplateAlias_basic (130.36s)
--- PASS: TestAccQuickSightTemplate_barChart (134.24s)
--- PASS: TestAccQuickSightTemplate_basic (135.17s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (145.11s)
--- PASS: TestAccQuickSightTemplate_table (174.50s)
--- PASS: TestAccQuickSightTemplate_update (191.18s)
--- PASS: TestAccQuickSightTemplate_tags (204.83s)
PASS

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ClaudiuDmtr]

Is this still on track to be merged?

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccQuickSightAnalysis_' PKG=quicksight ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/quicksight/... -v -count 1 -parallel 2  -run=TestAccQuickSightAnalysis_ -timeout 360m
=== RUN   TestAccQuickSightAnalysis_basic
=== PAUSE TestAccQuickSightAnalysis_basic
=== RUN   TestAccQuickSightAnalysis_disappears
=== PAUSE TestAccQuickSightAnalysis_disappears
=== RUN   TestAccQuickSightAnalysis_sourceEntity
=== PAUSE TestAccQuickSightAnalysis_sourceEntity
=== RUN   TestAccQuickSightAnalysis_update
=== PAUSE TestAccQuickSightAnalysis_update
=== RUN   TestAccQuickSightAnalysis_parametersConfig
=== PAUSE TestAccQuickSightAnalysis_parametersConfig
=== RUN   TestAccQuickSightAnalysis_forceDelete
=== PAUSE TestAccQuickSightAnalysis_forceDelete
=== RUN   TestAccQuickSightAnalysis_Definition_calculatedFields
=== PAUSE TestAccQuickSightAnalysis_Definition_calculatedFields
=== RUN   TestAccQuickSightAnalysis_theme
=== PAUSE TestAccQuickSightAnalysis_theme
=== CONT  TestAccQuickSightAnalysis_basic
=== CONT  TestAccQuickSightAnalysis_parametersConfig
--- PASS: TestAccQuickSightAnalysis_parametersConfig (42.10s)
=== CONT  TestAccQuickSightAnalysis_Definition_calculatedFields
--- PASS: TestAccQuickSightAnalysis_basic (42.12s)
=== CONT  TestAccQuickSightAnalysis_theme
--- PASS: TestAccQuickSightAnalysis_theme (41.14s)
=== CONT  TestAccQuickSightAnalysis_sourceEntity
--- PASS: TestAccQuickSightAnalysis_Definition_calculatedFields (41.17s)
=== CONT  TestAccQuickSightAnalysis_update
--- PASS: TestAccQuickSightAnalysis_sourceEntity (40.83s)
=== CONT  TestAccQuickSightAnalysis_disappears
--- PASS: TestAccQuickSightAnalysis_disappears (35.56s)
=== CONT  TestAccQuickSightAnalysis_forceDelete
--- PASS: TestAccQuickSightAnalysis_update (76.51s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (35.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	200.114s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.672s [no tests to run]

% make testacc TESTARGS='-run=TestAccQuickSightDataSource_' PKG=quicksight ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/quicksight/... -v -count 1 -parallel 2  -run=TestAccQuickSightDataSource_ -timeout 360m
=== RUN   TestAccQuickSightDataSource_basic
=== PAUSE TestAccQuickSightDataSource_basic
=== RUN   TestAccQuickSightDataSource_disappears
=== PAUSE TestAccQuickSightDataSource_disappears
=== RUN   TestAccQuickSightDataSource_tags
=== PAUSE TestAccQuickSightDataSource_tags
=== RUN   TestAccQuickSightDataSource_permissions
=== PAUSE TestAccQuickSightDataSource_permissions
=== RUN   TestAccQuickSightDataSource_name
=== PAUSE TestAccQuickSightDataSource_name
=== CONT  TestAccQuickSightDataSource_basic
=== CONT  TestAccQuickSightDataSource_permissions
--- PASS: TestAccQuickSightDataSource_basic (26.91s)
=== CONT  TestAccQuickSightDataSource_name
--- PASS: TestAccQuickSightDataSource_permissions (63.74s)
=== CONT  TestAccQuickSightDataSource_tags
--- PASS: TestAccQuickSightDataSource_name (42.31s)
=== CONT  TestAccQuickSightDataSource_disappears
--- PASS: TestAccQuickSightDataSource_disappears (21.73s)
--- PASS: TestAccQuickSightDataSource_tags (56.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	125.286s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.665s [no tests to run]

[github-actions]

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!