Applying bucket changes without some attributes doesn't reflect in state after terraform refresh

[Chhed13]

Related on #2296 (comment)

Confirming that changing ACLs also doesn't show up - had a bucket set to public today and my terraform with acl = "private" showed no changes required in the plan.

And #2296 (comment)

I'll prepare PR ASAP

[Chhed13]

I checked an ACLs (canned ACLs that we use) - looks like it's not possible to read them. s3conn.GetBucketAcl() return ACLs without canned, but s3conn.PutBucketAcl() take it.

request_payer attribute works fine
versioning - fails to update when it becomes disabled (deleted form config) after enabled.

[Chhed13]

checked lifecycle_rule - there is also an issue with refresh command if all rules were removed not by Terraform.

[Chhed13]

Current reproduction on versioning:

1. Apply

resource "aws_s3_bucket" "bucket" {
	bucket = "tf-test-bucket-%d"
	versioning {
	  enabled = true
	}
}

2a. Apply

resource "aws_s3_bucket" "bucket" {
	bucket = "tf-test-bucket-%d"
	versioning { }
}

Diff:

~ aws_s3_bucket.bucket
versioning.0.enabled: "true" => "false"

Looks good.
2b. Apply

resource "aws_s3_bucket" "bucket" {
	bucket = "tf-test-bucket-%d"
}

Diff:

empty

2c. Remove Computed: true from versioning attribute and apply

resource "aws_s3_bucket" "bucket" {
	bucket = "tf-test-bucket-%d"
}

Diff:

~ aws_s3_bucket.bucket
versioning.#: "1" => "0" <- should stay "1"
versioning.0.enabled: "true" => "false"

According to what AWS returns this section in state should always present:

 "versioning.#": "1",
 "versioning.0.enabled": "true/false",
 "versioning.0.mfa_delete": "false/true",

@bflad could you, please, help. What is the better way to force TF keep this section in sync?

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!