Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional KMS key ID in repository resource #35095

Merged
merged 22 commits into from
Jan 22, 2024

Conversation

obounaim
Copy link
Contributor

@obounaim obounaim commented Dec 29, 2023

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/codecommit Issues and PRs that pertain to the codecommit service. labels Dec 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 29, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Dec 29, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2024
% make testacc TESTARGS='-run=TestAccCodeCommitRepository_kmsKey' PKG=codecommit
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecommit/... -v -count 1 -parallel 20  -run=TestAccCodeCommitRepository_kmsKey -timeout 360m
=== RUN   TestAccCodeCommitRepository_kmsKey
=== PAUSE TestAccCodeCommitRepository_kmsKey
=== CONT  TestAccCodeCommitRepository_kmsKey
--- PASS: TestAccCodeCommitRepository_kmsKey (33.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	44.236s
`
@ewbankkit ewbankkit marked this pull request as ready for review January 22, 2024 13:10
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jan 22, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit changed the title [WIP] Add support for optional KMS key ID in repository resource Add support for optional KMS key ID in repository resource Jan 22, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 22, 2024
…dException: Repository trigger branch name list cannot be null' error.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeCommit' PKG=codecommit ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecommit/... -v -count 1 -parallel 3  -run=TestAccCodeCommit -timeout 360m
=== RUN   TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== RUN   TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
=== RUN   TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
=== RUN   TestAccCodeCommitApprovalRuleTemplateDataSource_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplateDataSource_basic
=== RUN   TestAccCodeCommitApprovalRuleTemplate_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_basic
=== RUN   TestAccCodeCommitApprovalRuleTemplate_disappears
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_disappears
=== RUN   TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
=== RUN   TestAccCodeCommitApprovalRuleTemplate_updateName
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_updateName
=== RUN   TestAccCodeCommitRepositoryDataSource_basic
=== PAUSE TestAccCodeCommitRepositoryDataSource_basic
=== RUN   TestAccCodeCommitRepository_basic
=== PAUSE TestAccCodeCommitRepository_basic
=== RUN   TestAccCodeCommitRepository_withChanges
=== PAUSE TestAccCodeCommitRepository_withChanges
=== RUN   TestAccCodeCommitRepository_CreateDefault_branch
=== PAUSE TestAccCodeCommitRepository_CreateDefault_branch
=== RUN   TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
=== PAUSE TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
=== RUN   TestAccCodeCommitRepository_tags
=== PAUSE TestAccCodeCommitRepository_tags
=== RUN   TestAccCodeCommitRepository_UpdateNameAndTags
=== PAUSE TestAccCodeCommitRepository_UpdateNameAndTags
=== RUN   TestAccCodeCommitRepository_kmsKey
=== PAUSE TestAccCodeCommitRepository_kmsKey
=== RUN   TestAccCodeCommitTrigger_basic
=== PAUSE TestAccCodeCommitTrigger_basic
=== CONT  TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== CONT  TestAccCodeCommitRepository_basic
=== CONT  TestAccCodeCommitApprovalRuleTemplate_disappears
--- PASS: TestAccCodeCommitApprovalRuleTemplate_disappears (20.44s)
=== CONT  TestAccCodeCommitRepositoryDataSource_basic
--- PASS: TestAccCodeCommitRepository_basic (24.04s)
=== CONT  TestAccCodeCommitApprovalRuleTemplate_updateName
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_basic (24.86s)
=== CONT  TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
--- PASS: TestAccCodeCommitRepositoryDataSource_basic (19.80s)
=== CONT  TestAccCodeCommitApprovalRuleTemplateDataSource_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplateDataSource_basic (18.61s)
=== CONT  TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateName (38.35s)
=== CONT  TestAccCodeCommitApprovalRuleTemplate_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription (37.79s)
=== CONT  TestAccCodeCommitRepository_tags
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository (20.87s)
=== CONT  TestAccCodeCommitTrigger_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplate_basic (23.94s)
=== CONT  TestAccCodeCommitRepository_kmsKey
--- PASS: TestAccCodeCommitTrigger_basic (21.11s)
=== CONT  TestAccCodeCommitRepository_UpdateNameAndTags
--- PASS: TestAccCodeCommitRepository_tags (64.50s)
=== CONT  TestAccCodeCommitRepository_CreateDefault_branch
--- PASS: TestAccCodeCommitRepository_kmsKey (44.22s)
=== CONT  TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
--- PASS: TestAccCodeCommitRepository_UpdateNameAndTags (45.29s)
=== CONT  TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
--- PASS: TestAccCodeCommitRepository_CreateDefault_branch (24.85s)
=== CONT  TestAccCodeCommitRepository_withChanges
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_disappears (21.93s)
--- PASS: TestAccCodeCommitRepository_CreateAndUpdateDefault_branch (35.18s)
--- PASS: TestAccCodeCommitRepository_withChanges (32.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	195.312s

@ewbankkit
Copy link
Contributor

@obounaim Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 15980f4 into hashicorp:main Jan 22, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 22, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/codecommit Issues and PRs that pertain to the codecommit service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: support kms_key_id in aws_codecommit_repository
3 participants