WORKING: f-aws-computeoptimizer-recommendation-preferences new resource

[hunttom]

Description

Creates new AWS Compute Optimizer Resource to put recommendation preferences.

Relations

Closes #23945.

References

• AWS Compute Optimizer Recommendations API: docs
• AWS Compute Optimizer Recommendations Go V2: docs

Output from Acceptance Testing

CURRENTLY WORKING - OPEN QUESTIONS BEFORE TESTS CAN BE PUSHED.

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[hunttom]

@ewbankkit - (Or anyone else who might know) I have a few questions about validation logic within this specific resource. All questions are marked with a // TODO

Questions are thus:

• Confirm validation types using ValidateDiagFunc: enum.Validate[types.<VARIOUS>](),
• Identify Validation logic for:
  • external_metrics_preference: Requires that resource_type is set to EC2Instance How would I do that?
• What ID should I set for this resource since no ARN is created? I was thinking of AWS Account but want to get the official stance? (resource_type is needed for create. resource_type and recommendation_preference_name is needed for delete)
• Line Validate types required.

Thanks for your help

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccComputeOptimizer_serial/RecommendationPreferences' PKG=computeoptimizer 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/computeoptimizer/... -v -count 1 -parallel 20  -run=TestAccComputeOptimizer_serial/RecommendationPreferences -timeout 360m
=== RUN   TestAccComputeOptimizer_serial
=== PAUSE TestAccComputeOptimizer_serial
=== CONT  TestAccComputeOptimizer_serial
=== RUN   TestAccComputeOptimizer_serial/RecommendationPreferences
=== RUN   TestAccComputeOptimizer_serial/RecommendationPreferences/basic
=== RUN   TestAccComputeOptimizer_serial/RecommendationPreferences/disappears
=== RUN   TestAccComputeOptimizer_serial/RecommendationPreferences/preferredResources
=== RUN   TestAccComputeOptimizer_serial/RecommendationPreferences/utilizationPreferences
--- PASS: TestAccComputeOptimizer_serial (61.75s)
    --- PASS: TestAccComputeOptimizer_serial/RecommendationPreferences (61.75s)
        --- PASS: TestAccComputeOptimizer_serial/RecommendationPreferences/basic (14.40s)
        --- PASS: TestAccComputeOptimizer_serial/RecommendationPreferences/disappears (11.26s)
        --- PASS: TestAccComputeOptimizer_serial/RecommendationPreferences/preferredResources (13.80s)
        --- PASS: TestAccComputeOptimizer_serial/RecommendationPreferences/utilizationPreferences (22.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/computeoptimizer	66.557s

% make testacc TESTARGS='-run=TestAccComputeOptimizer_serial/EnrollmentStatus' PKG=computeoptimizer
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/computeoptimizer/... -v -count 1 -parallel 20  -run=TestAccComputeOptimizer_serial/EnrollmentStatus -timeout 360m
=== RUN   TestAccComputeOptimizer_serial
=== PAUSE TestAccComputeOptimizer_serial
=== CONT  TestAccComputeOptimizer_serial
=== RUN   TestAccComputeOptimizer_serial/EnrollmentStatus
=== RUN   TestAccComputeOptimizer_serial/EnrollmentStatus/includeMemberAccounts
    enrollment_status_test.go:71: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccComputeOptimizer_serial/EnrollmentStatus/basic
--- PASS: TestAccComputeOptimizer_serial (26.51s)
    --- PASS: TestAccComputeOptimizer_serial/EnrollmentStatus (26.51s)
        --- SKIP: TestAccComputeOptimizer_serial/EnrollmentStatus/includeMemberAccounts (0.73s)
        --- PASS: TestAccComputeOptimizer_serial/EnrollmentStatus/basic (25.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/computeoptimizer	31.328s

[ewbankkit]

@hunttom Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!