Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: AWS WAFv2 ACL Support for Header Order match statement for request inspection #35377

Closed
hspencer77 opened this issue Jan 18, 2024 · 3 comments · Fixed by #35521
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@hspencer77
Copy link

hspencer77 commented Jan 18, 2024

Description

aws_wafv2_web_acl currently doesn't support Header Order match statement for request inspection.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

rule {
        name     = "incorrect-header-order"

        action {
            .....
        }

        statement {
            ....
                statement {
                    byte_match_statement {
                        positional_constraint = "STARTS_WITH"
                        
                        ## header order example for 'search_string'. AWS WAF separates the header names in the string using colons and no added spaces, for example host:user-agent:accept:authorization:referer.
                        
                        search_string         = "host:content-length" 

                        field_to_match {
                          header_order {
                             oversize_handling = "CONTINUE|MATCH|NO_MATCH"
                          }
                        }

                        text_transformation {
                         ....... 
                        }
                    }
                }
        .....

References

Would you like to implement a fix?

None

@hspencer77 hspencer77 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 18, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2024
@justinretzolk justinretzolk added service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2024
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 29, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
2 participants