Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] - Implement aws_apprunner_deployment #35758

Merged
merged 28 commits into from
Feb 23, 2024

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Feb 11, 2024

Description

Features the creation of a new App Runner resource: aws_apprunner_deployment

Relations

Closes #34835

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppRunnerDeployment_ PKG=apprunner    rbenv:3.1.0
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerDeployment_'  -timeout 360m
=== RUN   TestAccAppRunnerDeployment_basic
=== PAUSE TestAccAppRunnerDeployment_basic
=== CONT  TestAccAppRunnerDeployment_basic
--- PASS: TestAccAppRunnerDeployment_basic (349.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	356.323s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apprunner Issues and PRs that pertain to the apprunner service. labels Feb 11, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 11, 2024
@github-actions github-actions bot added the generators Relates to code generators. label Feb 11, 2024
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2024
@bschaatsbergen bschaatsbergen marked this pull request as ready for review February 14, 2024 13:51
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 20, 2024
@ewbankkit ewbankkit self-assigned this Feb 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 20, 2024
@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for this 👏.
Everything looks great, but do you mind renaming the resource to just aws_apprunner_deployment?

@bschaatsbergen bschaatsbergen changed the title [New Resource] - Implement aws_apprunner_start_deployment [New Resource] - Implement aws_apprunner_deployment Feb 21, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerDeployment_' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerDeployment_ -timeout 360m
=== RUN   TestAccAppRunnerDeployment_basic
=== PAUSE TestAccAppRunnerDeployment_basic
=== CONT  TestAccAppRunnerDeployment_basic
--- PASS: TestAccAppRunnerDeployment_basic (332.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	354.158s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b9d9303 into hashicorp:main Feb 23, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 23, 2024
@bschaatsbergen bschaatsbergen deleted the f/start-deployment-app-runner branch February 23, 2024 21:10
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: New Resource aws_apprunner_start_deployment
2 participants