Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_redshift_data_shares: new data source #35937

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Feb 22, 2024

Description

This data source will allow practitioners to list existing Redshift data shares in a given region.

Relations

Closes #35915

References

Output from Acceptance Testing

% make testacc PKG=redshift TESTS=TestAccRedshiftDataSharesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftDataSharesDataSource_'  -timeout 360m

--- PASS: TestAccRedshiftDataSharesDataSource_basic (298.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   305.822s

@jar-b jar-b added the new-data-source Introduces a new data source. label Feb 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. labels Feb 22, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 22, 2024
@jar-b jar-b force-pushed the f-redshift_data_share-datasource branch from b6ff6d7 to dafc6a3 Compare February 22, 2024 16:06
This data source will allow practitioners to list existing Redshift data shares in a given region.

```
make testacc PKG=redshift TESTS=TestAccRedshiftDataSharesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftDataSharesDataSource_'  -timeout 360m

--- PASS: TestAccRedshiftDataSharesDataSource_basic (298.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   305.822s
```
@jar-b jar-b force-pushed the f-redshift_data_share-datasource branch from dafc6a3 to fd82cf3 Compare February 22, 2024 20:29
@jar-b jar-b merged commit f7831f9 into main Feb 27, 2024
45 checks passed
@jar-b jar-b deleted the f-redshift_data_share-datasource branch February 27, 2024 14:15
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 27, 2024
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b changed the title d/aws_redshift_data_sources: new data source d/aws_redshift_data_shares: new data source Mar 13, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/redshift Issues and PRs that pertain to the redshift service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_redshift_data_shares
1 participant