Fix/Enhancement: Add application_tag attribute to aws_servicecatalogappregistry_application

[fatbasstard]

Description

This PR adds the application_tag attribute to the aws_servicecatalogappregistry_application resource. There is a design flaw in the new resource. It's not the Application's ARN that has to be assigned to the resource.

The actual tag(s) (key and name) are available in the SDK so just needs to be added.

This PR adds the new attribute and updates the documentation. Also implemented this in the tests

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccServiceCatalogAppRegistryApplication PKG=servicecatalogappregistry
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryApplication'  -timeout 360m
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplication_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_disappears
=== PAUSE TestAccServiceCatalogAppRegistryApplication_disappears
=== RUN   TestAccServiceCatalogAppRegistryApplication_update
=== PAUSE TestAccServiceCatalogAppRegistryApplication_update
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryApplication_disappears
=== CONT  TestAccServiceCatalogAppRegistryApplication_update
=== CONT  TestAccServiceCatalogAppRegistryApplication_basic
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_basic (8.73s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_disappears (8.97s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_basic (10.32s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_update (19.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  24.110s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[fatbasstard]

@jar-b Can you take a look at this PR? Found out it's missing a vital feature in order to make it work decently..

[jar-b]

Thanks for the fix! I'll assign myself and get it reviewed before next weeks release.

[jar-b]

LGTM 🎉

% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryApplication
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryApplication'  -timeout 360m

--- PASS: TestAccServiceCatalogAppRegistryApplication_disappears (13.72s)
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_basic (13.81s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_basic (15.37s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_update (28.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  33.679s

[jar-b]

Thanks for your contribution, @fatbasstard! 👍

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.