ECS Service Alarm Config read uses wrong key

[spangaer]

When you configure

resource "aws_ecs_service" "ext" {
...

  alarms {
    enable   = true
    rollback = false
    alarm_names = [
      "xyz"
    ]
  }
}

The rollback flag is always set to true. Even though it gets detected as it should be set to false.

Truth be told, the setting also doesn't seem to do anything meaningful on the AWS side with that parameter combination. While it's not documented to not be meaningful.

Still you can configure it as such with the AWS console or API, so given line is a bug none the less.

(I have not touched or run acceptance test, I hope that can be taken care of by the receiving end of this PR)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @spangaer 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSService_basic\|TestAccECSService_alarms' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSService_basic\|TestAccECSService_alarms -timeout 360m
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_alarmsAdd
=== PAUSE TestAccECSService_alarmsAdd
=== RUN   TestAccECSService_alarmsUpdate
=== PAUSE TestAccECSService_alarmsUpdate
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSService_alarmsAdd
=== CONT  TestAccECSService_alarmsUpdate
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_basic (100.36s)
--- PASS: TestAccECSService_alarmsAdd (100.49s)
--- PASS: TestAccECSService_alarmsUpdate (100.52s)
--- PASS: TestAccECSService_basicImport (205.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	216.976s

[ewbankkit]

@spangaer Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.