Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_ec2_transit_gateway_peering_attachment support for dynamic routing #36902

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #36412

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transitgateway Issues and PRs that pertain to the transitgateway service. labels Apr 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2024
@ewbankkit ewbankkit self-assigned this Apr 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 15, 2024
@ewbankkit ewbankkit removed their assignment Apr 15, 2024
@ewbankkit ewbankkit self-assigned this Jul 2, 2024
# Conflicts:
#	internal/service/ec2/transitgateway_peering_attachment.go
#	internal/service/ec2/transitgateway_peering_attachment_test.go
#	internal/service/ec2/transitgateway_test.go
@ewbankkit ewbankkit requested a review from a team as a code owner July 2, 2024 12:44
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PeeringAttachment_' PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PeeringAttachment_ -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_DifferentAccount
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_DifferentAccount
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_options
    transitgateway_peering_attachment_test.go:66: IncorrectState: You cannot create a dynamic peering attachment
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_basic
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_basic
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_disappears
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_disappears
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_tags
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_tags
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_DifferentAccount
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_disappears
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_tags
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_basic
=== NAME  TestAccTransitGateway_serial/PeeringAttachment_DifferentAccount
    transitgateway_peering_attachment_test.go:197: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- SKIP: TestAccTransitGateway_serial/PeeringAttachment_options (0.00s)
    --- SKIP: TestAccTransitGateway_serial/PeeringAttachment_DifferentAccount (1.02s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment_disappears (254.30s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment_tags (299.77s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment_basic (317.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	321.992s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0738851 into hashicorp:main Jul 2, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 2, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the f-aws_ec2_transit_gateway_peering_attachment branch July 16, 2024 16:59
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/transitgateway Issues and PRs that pertain to the transitgateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add dynamic routing option to aws_ec2_transit_gateway_peering_attachment
2 participants