feat: Add GitLab support to report_build_status and build_status_config for aws_codebuild_project #36942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add GitLab and GitLab Self Managed support to the
report_build_status
andbuild_status_config
arguments in theaws_codebuild_project
resource. The expansion code apparently has code logic to detect the build type to determine whether these arguments/config blocks should be added. Personally I think it should be deferred to the API to determine that, but to fix the issue quickly I just follow suit for now.Relations
Closes #36937
References
Referred to ProjectSource for specs and documentation wordings. Also cross-checked the availability of options in the AWS Management Console - note that
git_submodules_config
is grayed out (and thus not supported) for GitLab source types.Output from Acceptance Testing
Note: Unfortunately I don't really have the right setup to test GitHub and BitBucket source types, so I can't really test them. I also don't have GitLab so I can't write new tests for it either even when I wanted to. If any maintainer can facilitate adding a test cases for GitLab source types, that's be greatly appreciated.