Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alarm Specification feature to auto scaling groups instance refresh preferences #36954

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

sidyashwanth
Copy link

@sidyashwanth sidyashwanth commented Apr 17, 2024

Description

Add AlarmSpecification feature to auto scaling groups instance refresh preferences.

References

https://docs.aws.amazon.com/autoscaling/ec2/userguide/instance-refresh-rollback.html#instance-refresh-using-auto-rollback

Closes #34662.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sidyashwanth 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@sidyashwanth sidyashwanth changed the title Add Alarm Specification feature to auto scaling groups instance refre… Add Alarm Specification feature to auto scaling groups instance refresh preference Apr 17, 2024
@sidyashwanth sidyashwanth changed the title Add Alarm Specification feature to auto scaling groups instance refresh preference Add Alarm Specification feature to auto scaling groups instance refresh preferences Apr 17, 2024
@sidyashwanth sidyashwanth marked this pull request as ready for review April 17, 2024 15:08
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2024
@ewbankkit ewbankkit self-assigned this Apr 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 18, 2024
@sidyashwanth
Copy link
Author

@ewbankkit Hey sorry, I think I overwrote your changes just now. Please re-push. I'll keep off from now on unless you need me to do something.

# Conflicts:
#	internal/service/autoscaling/group.go
#	internal/service/autoscaling/group_test.go
#	website/docs/r/autoscaling_group.html.markdown
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_InstanceRefresh_\|TestAccAutoScalingGroup_basic' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingGroup_InstanceRefresh_\|TestAccAutoScalingGroup_basic -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
--- PASS: TestAccAutoScalingGroup_basic (66.46s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_autoRollback
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (217.55s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification (220.59s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_autoRollback (193.95s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (214.80s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (351.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	586.479s

@ewbankkit
Copy link
Contributor

@sidyashwanth Thanks for the contribution 🎉 👏.

@sidyashwanth
Copy link
Author

@ewbankkit thanks for prioritising and approving. Hope to see it in the next version soon.

@ewbankkit ewbankkit merged commit 30c3298 into hashicorp:main Apr 18, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 18, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add AlarmSpecification/Alarms to aws_autoscaling_group.instance_refresh
2 participants