Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_securitylake_subscriber_notification: Fixes #37332

Merged
merged 16 commits into from
May 8, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 7, 2024

Description

Various fixes to aws_securitylake_subscriber_notification:

  • Deprecates endpoint_id and adds subscriber_endpoint to match documentation and API
  • Requires value for configuration.https_notification_configuration.endpoint
  • Better handles import by reading available data from API
  • Marks configuration.https_notification_configuration. authorization_api_key_value as Sensitive
  • Allows resource to be modified in-place

Relations

Relates #36325

Output from Acceptance Testing

% make testacc PKG=securitylake TESTS=TestAccSecurityLake_serial/SubscriberNotification

--- PASS: TestAccSecurityLake_serial (481.97s)
    --- PASS: TestAccSecurityLake_serial/SubscriberNotification (481.97s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/sqs_basic (62.10s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/apiKeyNameOnly (79.17s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/apiKey (100.66s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/disappears (63.29s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/https_basic (62.37s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/update (114.37s)

Copy link

github-actions bot commented May 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/securitylake Issues and PRs that pertain to the securitylake service. labels May 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison force-pushed the td-seclake-subscribernotification-fixes branch from d7b4f6e to 97f9bd7 Compare May 7, 2024 23:22
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 22d3ce3 into main May 8, 2024
44 checks passed
@gdavison gdavison deleted the td-seclake-subscribernotification-fixes branch May 8, 2024 23:46
@github-actions github-actions bot added this to the v5.49.0 milestone May 8, 2024
github-actions bot pushed a commit that referenced this pull request May 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/securitylake Issues and PRs that pertain to the securitylake service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants