Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nil check for notification_property on the glue_job resource #37347

Merged

Conversation

DanielRieske
Copy link
Contributor

Description

Added a check for nil values.

Relations

Closes #37325

References

Output from Acceptance Testing

terraform-provider-aws git:(main) make testacc TESTARGS='-run=TestAccGlueJob_notificationProperty' PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueJob_notificationProperty -timeout 360m
=== RUN   TestAccGlueJob_notificationProperty
=== PAUSE TestAccGlueJob_notificationProperty
=== CONT  TestAccGlueJob_notificationProperty
--- PASS: TestAccGlueJob_notificationProperty (59.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       64.144s

Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. labels May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 8, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=glue TESTS=TestAccGlueJob_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m

--- PASS: TestAccGlueJob_rayJob (26.52s)
--- PASS: TestAccGlueJob_disappears (31.22s)
--- PASS: TestAccGlueJob_basicStreaming (33.86s)
--- PASS: TestAccGlueJob_basic (36.19s)
--- PASS: TestAccGlueJob_executionClass (49.62s)
--- PASS: TestAccGlueJob_streamingTimeout (50.39s)
--- PASS: TestAccGlueJob_maxCapacity (52.65s)
--- PASS: TestAccGlueJob_defaultArguments (52.76s)
--- PASS: TestAccGlueJob_timeout (53.31s)
--- PASS: TestAccGlueJob_nonOverridableArguments (53.37s)
--- PASS: TestAccGlueJob_description (53.43s)
--- PASS: TestAccGlueJob_security (53.47s)
--- PASS: TestAccGlueJob_executionProperty (53.50s)
--- PASS: TestAccGlueJob_command (53.56s)
--- PASS: TestAccGlueJob_maxRetries (55.50s)
--- PASS: TestAccGlueJob_notificationProperty (55.52s)
--- PASS: TestAccGlueJob_tags (60.76s)
--- PASS: TestAccGlueJob_glueVersion (61.22s)
--- PASS: TestAccGlueJob_pythonShell (69.43s)
--- PASS: TestAccGlueJob_workerType (76.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       81.796s

@jar-b
Copy link
Member

jar-b commented May 10, 2024

Thanks for your contribution, @DanielRieske! 👍

@jar-b jar-b merged commit 18ca4ad into hashicorp:main May 10, 2024
33 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 10, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. external-maintainer Contribution from a trusted external contributor. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
4 participants