Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSx: Fix tags regressions #37353

Merged
merged 4 commits into from
May 8, 2024
Merged

FSx: Fix tags regressions #37353

merged 4 commits into from
May 8, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 8, 2024

Description

Describe API calls don't return tags.

Relations

Closes #37346.
Relates #36511.

References

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPStorageVirtualMachineDataSource_Id\|TestAccFSxONTAPStorageVirtualMachine_basic\|TestAccFSxONTAPStorageVirtualMachine_tags' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxONTAPStorageVirtualMachineDataSource_Id\|TestAccFSxONTAPStorageVirtualMachine_basic\|TestAccFSxONTAPStorageVirtualMachine_tags -timeout 720m
=== RUN   TestAccFSxONTAPStorageVirtualMachineDataSource_Id
=== PAUSE TestAccFSxONTAPStorageVirtualMachineDataSource_Id
=== RUN   TestAccFSxONTAPStorageVirtualMachine_basic
=== PAUSE TestAccFSxONTAPStorageVirtualMachine_basic
=== RUN   TestAccFSxONTAPStorageVirtualMachine_tags
=== PAUSE TestAccFSxONTAPStorageVirtualMachine_tags
=== CONT  TestAccFSxONTAPStorageVirtualMachineDataSource_Id
=== CONT  TestAccFSxONTAPStorageVirtualMachine_basic
=== CONT  TestAccFSxONTAPStorageVirtualMachine_tags
--- PASS: TestAccFSxONTAPStorageVirtualMachine_basic (2840.74s)
--- PASS: TestAccFSxONTAPStorageVirtualMachine_tags (2854.03s)
--- PASS: TestAccFSxONTAPStorageVirtualMachineDataSource_Id (2978.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2989.988s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxOpenZFSFileSystem_basic\|TestAccFSxOpenZFSFileSystem_tags\|TestAccFSxOpenZFSFileSystem_copyTags' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxOpenZFSFileSystem_basic\|TestAccFSxOpenZFSFileSystem_tags\|TestAccFSxOpenZFSFileSystem_copyTags -timeout 720m
=== RUN   TestAccFSxOpenZFSFileSystem_basic
=== PAUSE TestAccFSxOpenZFSFileSystem_basic
=== RUN   TestAccFSxOpenZFSFileSystem_tags
=== PAUSE TestAccFSxOpenZFSFileSystem_tags
=== RUN   TestAccFSxOpenZFSFileSystem_copyTags
=== PAUSE TestAccFSxOpenZFSFileSystem_copyTags
=== CONT  TestAccFSxOpenZFSFileSystem_basic
=== CONT  TestAccFSxOpenZFSFileSystem_copyTags
=== CONT  TestAccFSxOpenZFSFileSystem_tags
--- PASS: TestAccFSxOpenZFSFileSystem_tags (531.42s)
--- PASS: TestAccFSxOpenZFSFileSystem_copyTags (577.81s)
--- PASS: TestAccFSxOpenZFSFileSystem_basic (680.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	691.110s

Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. labels May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 8, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label May 8, 2024
@ewbankkit ewbankkit merged commit b29f63e into main May 8, 2024
37 checks passed
@ewbankkit ewbankkit deleted the b-fsx-tags-regression branch May 8, 2024 18:17
@github-actions github-actions bot added this to the v5.49.0 milestone May 8, 2024
github-actions bot pushed a commit that referenced this pull request May 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant