Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/lakeformation_data_cells_filter: fix error when using row_filter.all_rows_wildcard #37433

Merged
merged 3 commits into from
May 10, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Relations

Closes #36574

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccLakeFormation_serial/DataCellsFilter/" PKG=lakeformation

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/DataCellsFilter/ -timeout 360m
--- PASS: TestAccLakeFormation_serial (60.35s)
    --- PASS: TestAccLakeFormation_serial/DataCellsFilter (60.35s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/columnWildcard (12.59s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/disappears (12.74s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/rowFilter (20.37s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/basic (14.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	65.782s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels May 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 10, 2024
@johnsonaj johnsonaj merged commit b52d7b4 into main May 10, 2024
67 checks passed
@johnsonaj johnsonaj deleted the b-lakeformation_data_cells_filter_rows branch May 10, 2024 19:05
@github-actions github-actions bot added this to the v5.50.0 milestone May 10, 2024
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LakeFormation data cells filter error with using all_rows_wildcard attribute
1 participant