Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/app fabric app authorization #37468

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Feature/app fabric app authorization #37468

merged 11 commits into from
Jun 12, 2024

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented May 13, 2024 •
edited by ewbankkit
Loading

Description

This PR adds a resource for aws_appfabric_app_authorization

https://docs.aws.amazon.com/appfabric/latest/api/API_CreateAppAuthorization.html

Relations

Relates #34549.
Requires #37468.

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric  ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 1  -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/AppAuthorization
=== RUN   TestAccAppFabric_serial/AppAuthorization/tags
=== PAUSE TestAccAppFabric_serial/AppAuthorization/tags
=== RUN   TestAccAppFabric_serial/AppAuthorization/basic
=== PAUSE TestAccAppFabric_serial/AppAuthorization/basic
=== RUN   TestAccAppFabric_serial/AppAuthorization/disappears
=== PAUSE TestAccAppFabric_serial/AppAuthorization/disappears
=== RUN   TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== PAUSE TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN   TestAccAppFabric_serial/AppAuthorization/oath2Update
=== PAUSE TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT  TestAccAppFabric_serial/AppAuthorization/tags
=== CONT  TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== CONT  TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT  TestAccAppFabric_serial/AppAuthorization/disappears
=== CONT  TestAccAppFabric_serial/AppAuthorization/basic
--- PASS: TestAccAppFabric_serial (98.97s)
    --- PASS: TestAccAppFabric_serial/AppAuthorization (0.00s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/tags (32.37s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (22.05s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (22.09s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (10.40s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/basic (12.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	104.407s

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/appfabric Issues and PRs that pertain to the appfabric service. and removed size/XL Managed by automation to categorize the size of a PR. labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels May 13, 2024
@markoskandylis markoskandylis marked this pull request as ready for review May 13, 2024 14:46
@markoskandylis
Copy link
Contributor Author

After fixing the tests:
make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 1 -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT TestAccAppFabric_serial
=== RUN TestAccAppFabric_serial/AppAuthorization
=== RUN TestAccAppFabric_serial/AppAuthorization/disappears
=== PAUSE TestAccAppFabric_serial/AppAuthorization/disappears
=== RUN TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== PAUSE TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN TestAccAppFabric_serial/AppAuthorization/oath2Update
=== PAUSE TestAccAppFabric_serial/AppAuthorization/oath2Update
=== RUN TestAccAppFabric_serial/AppAuthorization/tags
=== PAUSE TestAccAppFabric_serial/AppAuthorization/tags
=== RUN TestAccAppFabric_serial/AppAuthorization/basic
=== PAUSE TestAccAppFabric_serial/AppAuthorization/basic
=== CONT TestAccAppFabric_serial/AppAuthorization/disappears
=== CONT TestAccAppFabric_serial/AppAuthorization/tags
=== CONT TestAccAppFabric_serial/AppAuthorization/basic
=== CONT TestAccAppFabric_serial/AppAuthorization/oath2Update
=== CONT TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
--- PASS: TestAccAppFabric_serial (97.39s)
--- PASS: TestAccAppFabric_serial/AppAuthorization (0.00s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (10.64s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/tags (31.34s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/basic (11.82s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (21.69s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (21.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appfabric 102.808s

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024
meetreks
meetreks reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@meetreks meetreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent code, job well done. Just some minor edits to follow.

internal/service/appfabric/app_authorization.go Show resolved Hide resolved
internal/service/appfabric/app_authorization.go Show resolved Hide resolved
internal/service/appfabric/app_authorization_test.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_authorization_test.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_authorization_test.go Outdated Show resolved Hide resolved
internal/service/appfabric/appfabric_test.go Outdated Show resolved Hide resolved
website/docs/r/appfabric_app_authorization.html.markdown Outdated Show resolved Hide resolved
@ewbankkit ewbankkit mentioned this pull request Jun 11, 2024
Merged
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jun 11, 2024
@ewbankkit
Merge branch 'main' into HEAD
5a408ff 
# Conflicts:
#	internal/service/appfabric/appfabric_test.go
#	internal/service/appfabric/exports_test.go
#	internal/service/appfabric/service_package_gen.go
@ewbankkit ewbankkit self-assigned this Jun 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 11, 2024
ewbankkit
ewbankkit approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 20  -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/AppAuthorization
=== RUN   TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN   TestAccAppFabric_serial/AppAuthorization/oath2Update
=== RUN   TestAccAppFabric_serial/AppAuthorization/tags
=== RUN   TestAccAppFabric_serial/AppAuthorization/basic
=== RUN   TestAccAppFabric_serial/AppAuthorization/disappears
--- PASS: TestAccAppFabric_serial (168.77s)
    --- PASS: TestAccAppFabric_serial/AppAuthorization (168.77s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (41.93s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (34.36s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/tags (46.55s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/basic (24.49s)
        --- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (21.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	173.143s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8cf6297 into hashicorp:main Jun 12, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.54.0 milestone Jun 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meetreks meetreks meetreks left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/appfabric Issues and PRs that pertain to the appfabric service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.54.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markoskandylis @ewbankkit @meetreks @justinretzolk