Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_appfabric_app_bundle resource #37542

Merged
merged 31 commits into from
Jun 11, 2024
Merged

add aws_appfabric_app_bundle resource #37542

merged 31 commits into from
Jun 11, 2024

Conversation

walkoaw
Copy link
Contributor

@walkoaw walkoaw commented May 15, 2024

Description

This PR adds a resource for aws_appfabric_appbundle

Relations

Relates #34549

References

AppFabric AppBundle Docs

Output from Acceptance Testing

% make testacc TESTS=TestAccAppFabricAppBundle PKG=appfabric                                                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.0 test ./internal/service/appfabric/... -v -count 1 -parallel 20 -run='TestAccAppFabricAppBundle'  -timeout 360m
=== RUN   TestAccAppFabricAppBundle_basic
=== PAUSE TestAccAppFabricAppBundle_basic
=== RUN   TestAccAppFabricAppBundle_disappears
=== PAUSE TestAccAppFabricAppBundle_disappears
=== CONT  TestAccAppFabricAppBundle_basic
=== CONT  TestAccAppFabricAppBundle_disappears
--- PASS: TestAccAppFabricAppBundle_disappears (12.62s)
--- PASS: TestAccAppFabricAppBundle_basic (15.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appfabric  19.935s```

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/appfabric Issues and PRs that pertain to the appfabric service. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @walkoaw 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
Copy link
Contributor

@meetreks meetreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Code, well done. Some minor edits required.

Also -- need 2 more files one is for change log and another for documentation - you can check the contributor guide for the same.

internal/service/appfabric/app_bundle.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_bundle.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_bundle_test.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_bundle_test.go Outdated Show resolved Hide resolved
internal/service/appfabric/app_bundle_test.go Show resolved Hide resolved
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@walkoaw
Copy link
Contributor Author

walkoaw commented May 29, 2024

All comments have been addressed and documentation has been added.

Copy link
Contributor

@meetreks meetreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good . Some minor edits required

  1. As you have an optional field like "customer_managed_key_identifier": schema.StringAttribute{ Optional: true, }, then you need a test for the same.
  2. You need a couple of additional tests for tags.

@breathingdust breathingdust added the partner Contribution from a partner. label Jun 5, 2024
# Conflicts:
#	internal/service/appfabric/service_package_gen.go
@ewbankkit ewbankkit self-assigned this Jun 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 10, 2024
@ewbankkit ewbankkit changed the title add aws_appfabric_appbundle resource add aws_appfabric_app_bundle resource Jun 11, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 11, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAppFabric_serial' PKG=appfabric
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 20  -run=TestAccAppFabric_serial -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/AppBundle
=== RUN   TestAccAppFabric_serial/AppBundle/cmk
=== RUN   TestAccAppFabric_serial/AppBundle/tags
=== RUN   TestAccAppFabric_serial/AppBundle/basic
=== RUN   TestAccAppFabric_serial/AppBundle/disappears
--- PASS: TestAccAppFabric_serial (119.61s)
    --- PASS: TestAccAppFabric_serial/AppBundle (119.61s)
        --- PASS: TestAccAppFabric_serial/AppBundle/cmk (27.74s)
        --- PASS: TestAccAppFabric_serial/AppBundle/tags (44.31s)
        --- PASS: TestAccAppFabric_serial/AppBundle/basic (22.68s)
        --- PASS: TestAccAppFabric_serial/AppBundle/disappears (24.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	124.117s

@ewbankkit
Copy link
Contributor

@walkoaw Thanks for the contribution 🎉 👏.

@walkoaw
Copy link
Contributor Author

walkoaw commented Jun 11, 2024

@ewbankkit Thank you for your assistance on the final review and edits!
Additionally, thank you @kaitheal!!

@ewbankkit ewbankkit merged commit 5dc00d1 into hashicorp:main Jun 11, 2024
45 checks passed
@github-actions github-actions bot added this to the v5.54.0 milestone Jun 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/appfabric Issues and PRs that pertain to the appfabric service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants