Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apigatewayv2 authorizer ConflictException #37732

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

uny
Copy link
Contributor

@uny uny commented May 28, 2024

Description

When attempting to simultaneously delete aws_apigatewayv2_authorizer and remove the authorizer from aws_apigatewayv2_route, a ConflictException occurs. To resolve this, introduce a retry mechanism for the deletion of aws_apigatewayv2_authorizer.

Relations

Closes #14812

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAPIGatewayV2Authorizer PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2Authorizer'  -timeout 360m
=== RUN   TestAccAPIGatewayV2Authorizer_basic
=== PAUSE TestAccAPIGatewayV2Authorizer_basic
=== RUN   TestAccAPIGatewayV2Authorizer_disappears
=== PAUSE TestAccAPIGatewayV2Authorizer_disappears
=== RUN   TestAccAPIGatewayV2Authorizer_credentials
=== PAUSE TestAccAPIGatewayV2Authorizer_credentials
=== RUN   TestAccAPIGatewayV2Authorizer_jwt
=== PAUSE TestAccAPIGatewayV2Authorizer_jwt
=== RUN   TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialMissingCacheTTL
=== PAUSE TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialMissingCacheTTL
=== RUN   TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialZeroCacheTTL
=== PAUSE TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialZeroCacheTTL
=== CONT  TestAccAPIGatewayV2Authorizer_basic
=== CONT  TestAccAPIGatewayV2Authorizer_jwt
=== CONT  TestAccAPIGatewayV2Authorizer_credentials
=== CONT  TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialZeroCacheTTL
=== CONT  TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialMissingCacheTTL
=== CONT  TestAccAPIGatewayV2Authorizer_disappears
--- PASS: TestAccAPIGatewayV2Authorizer_jwt (65.73s)
--- PASS: TestAccAPIGatewayV2Authorizer_disappears (66.47s)
--- PASS: TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialZeroCacheTTL (66.51s)
--- PASS: TestAccAPIGatewayV2Authorizer_basic (79.10s)
--- PASS: TestAccAPIGatewayV2Authorizer_credentials (85.22s)
--- PASS: TestAccAPIGatewayV2Authorizer_HTTPAPILambdaRequestAuthorizer_initialMissingCacheTTL (103.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	109.695s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. labels May 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 28, 2024
@uny uny marked this pull request as ready for review May 28, 2024 09:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @uny 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2024
@uny
Copy link
Contributor Author

uny commented Jun 3, 2024

Output from Acceptance Testing added.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayV2Authorizer_basic' PKG=apigatewayv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayV2Authorizer_basic -timeout 360m
=== RUN   TestAccAPIGatewayV2Authorizer_basic
=== PAUSE TestAccAPIGatewayV2Authorizer_basic
=== CONT  TestAccAPIGatewayV2Authorizer_basic
--- PASS: TestAccAPIGatewayV2Authorizer_basic (51.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	56.828s

@ewbankkit
Copy link
Contributor

@uny Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 6, 2024
@ewbankkit ewbankkit merged commit 9010509 into hashicorp:main Jun 6, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 6, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not delete AWS API Gateway authorizer using terraform due to conflict exceptions
3 participants