Add "io2" as a valid EBS volume type to EMR validation routine #37740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix aws_emr_managed_scaling_policy for compatibility with the behavior of emr_cluster that was fixed as a part of the next problem: hashicorp#16924 hashicorp#7783
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @atsalolikhin-spokeo 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
enhancement
github-actions
bot
added
the
documentation
|
info: @ewbankkit |
atsalolikhin-spokeo
changed the title
github-actions
bot
added
the
prioritized
This reverts commit f040b65.
…r id '...' is not valid" on Read and Delete.
…`0` on create when configured.
github-actions
bot
added
the
tests
ewbankkit
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_instanceCount\|TestAccEMRInstanceGroup_basic' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRInstanceGroup_instanceCount\|TestAccEMRInstanceGroup_basic -timeout 360m
=== RUN TestAccEMRInstanceGroup_basic
=== PAUSE TestAccEMRInstanceGroup_basic
=== RUN TestAccEMRInstanceGroup_instanceCountDecrease
=== PAUSE TestAccEMRInstanceGroup_instanceCountDecrease
=== RUN TestAccEMRInstanceGroup_instanceCountCreateZero
=== PAUSE TestAccEMRInstanceGroup_instanceCountCreateZero
=== CONT TestAccEMRInstanceGroup_basic
=== CONT TestAccEMRInstanceGroup_instanceCountCreateZero
=== CONT TestAccEMRInstanceGroup_instanceCountDecrease
--- PASS: TestAccEMRInstanceGroup_instanceCountCreateZero (459.14s)
--- PASS: TestAccEMRInstanceGroup_basic (674.17s)
--- PASS: TestAccEMRInstanceGroup_instanceCountDecrease (786.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 791.483s
|
@atsalolikhin-spokeo Thanks for the contribution 🎉 👏. |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
io2EBS volume storage type toaws_emr_cluster.EC2
r5binstances supportio2since July 2021: https://aws.amazon.com/blogs/aws/amazon-ebs-io2-block-express-volumes-with-amazon-ec2-r5b-instances-are-now-generally-available/https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-supported-instance-types.html says that
r5binstances are supported in e.g., us-east-1 (Virginia), us-west-2 (oregon), etc.AWS EMR FAQ says:
EMR Management Guide says:
Adding support for
io2allows us to add Provisioned IOPS (io2) EBS volumes.The desired use case is to be able to provision an EMR cluster with
io2volumes to increase disk I/O performance for a large data processing task.Relations
Relates #20248 (which was auto-closed but is still a pain point for us).
Closes #38837.
Closes #23029.
References