Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp_asn_extended #37815

Merged
merged 11 commits into from
Jun 6, 2024
Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jun 3, 2024

Description

Relations

Closes #37810

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSiteVPNCustomerGateway_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNCustomerGateway_'  -timeout 360m
=== RUN   TestAccSiteVPNCustomerGateway_basic
=== PAUSE TestAccSiteVPNCustomerGateway_basic
=== RUN   TestAccSiteVPNCustomerGateway_bgpASNExtended
=== PAUSE TestAccSiteVPNCustomerGateway_bgpASNExtended
=== RUN   TestAccSiteVPNCustomerGateway_disappears
=== PAUSE TestAccSiteVPNCustomerGateway_disappears
=== RUN   TestAccSiteVPNCustomerGateway_tags
=== PAUSE TestAccSiteVPNCustomerGateway_tags
=== RUN   TestAccSiteVPNCustomerGateway_deviceName
=== PAUSE TestAccSiteVPNCustomerGateway_deviceName
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== RUN   TestAccSiteVPNCustomerGateway_certificate
=== PAUSE TestAccSiteVPNCustomerGateway_certificate
=== CONT  TestAccSiteVPNCustomerGateway_basic
=== CONT  TestAccSiteVPNCustomerGateway_deviceName
=== CONT  TestAccSiteVPNCustomerGateway_tags
=== CONT  TestAccSiteVPNCustomerGateway_bgpASNExtended
=== CONT  TestAccSiteVPNCustomerGateway_certificate
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
=== CONT  TestAccSiteVPNCustomerGateway_disappears
--- PASS: TestAccSiteVPNCustomerGateway_disappears (60.87s)
--- PASS: TestAccSiteVPNCustomerGateway_deviceName (69.11s)
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (69.14s)
--- PASS: TestAccSiteVPNCustomerGateway_basic (69.35s)
--- PASS: TestAccSiteVPNCustomerGateway_bgpASNExtended (69.37s)
--- PASS: TestAccSiteVPNCustomerGateway_tags (97.30s)
--- PASS: TestAccSiteVPNCustomerGateway_certificate (109.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	124.445s

...

Copy link

github-actions bot commented Jun 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpnsite Issues and PRs that pertain to the vpnsite service. labels Jun 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 3, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 3, 2024
@johnsonaj johnsonaj self-assigned this Jun 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 5, 2024
@johnsonaj johnsonaj added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccSiteVPNCustomerGateway_\|TestAccSiteVPNCustomerGatewayDataSource_' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccSiteVPNCustomerGateway_\|TestAccSiteVPNCustomerGatewayDataSource_ -timeout 360m
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_filter (25.42s)
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_id (25.47s)
--- PASS: TestAccSiteVPNCustomerGateway_disappears (25.80s)
--- PASS: TestAccSiteVPNCustomerGateway_deviceName (27.75s)
--- PASS: TestAccSiteVPNCustomerGateway_bgpASNExtended (27.89s)
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (27.99s)
--- PASS: TestAccSiteVPNCustomerGateway_basic (28.07s)
--- PASS: TestAccSiteVPNCustomerGateway_tags (41.58s)
--- PASS: TestAccSiteVPNCustomerGateway_certificate (78.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	84.533s

@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for your contribution! 🎉

@johnsonaj johnsonaj merged commit efa6f2f into hashicorp:main Jun 6, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 6, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
@nikhil-goenka nikhil-goenka deleted the f/aws_customer_gateway branch June 16, 2024 13:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for extended BGP ASNs to aws_customer_gateway
2 participants