Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add managed_storage_configuration block to aws_ecs_cluster #37932

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jun 12, 2024

Description

This PR is to add the new managed_storage_configuration block to the aws_ecs_cluster resource to support ECS Fargate ephemeral storage encryption using CMK.

Relations

Closes #37922

References

Referred to CreateCluster for specs and wordings.

Output from Acceptance Testing

Note: TestAccECSCluster_managedStorageConfiguration is a new test case.

$ make testacc TESTS=TestAccECSCluster_ PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCluster_'  -timeout 360m
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_disappears
=== PAUSE TestAccECSCluster_disappears
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSCluster_serviceConnectDefaults
=== PAUSE TestAccECSCluster_serviceConnectDefaults
=== RUN   TestAccECSCluster_containerInsights
=== PAUSE TestAccECSCluster_containerInsights
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== RUN   TestAccECSCluster_managedStorageConfiguration
=== PAUSE TestAccECSCluster_managedStorageConfiguration
=== CONT  TestAccECSCluster_basic
=== CONT  TestAccECSCluster_containerInsights
=== CONT  TestAccECSCluster_tags
=== CONT  TestAccECSCluster_managedStorageConfiguration
=== CONT  TestAccECSCluster_serviceConnectDefaults
=== CONT  TestAccECSCluster_disappears
=== CONT  TestAccECSCluster_configuration
--- PASS: TestAccECSCluster_disappears (29.08s)
--- PASS: TestAccECSCluster_basic (31.81s)
--- PASS: TestAccECSCluster_tags (50.62s)
--- PASS: TestAccECSCluster_configuration (53.98s)
--- PASS: TestAccECSCluster_managedStorageConfiguration (66.62s)
--- PASS: TestAccECSCluster_containerInsights (68.43s)
--- PASS: TestAccECSCluster_serviceConnectDefaults (138.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        138.590s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. labels Jun 12, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jun 12, 2024
@acwwat acwwat force-pushed the f-aws_ecs_cluster-add_managed_storage_config branch from 89210f8 to ecbc4ff Compare June 12, 2024 06:48
@acwwat acwwat changed the title [WIP] feat: Add managed_storage_configuration block to aws_ecs_cluster feat: Add managed_storage_configuration block to aws_ecs_cluster Jun 12, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 13, 2024
@matthewbarreiro
Copy link

Any ETA on when this will be reviewed and merged? I have several customers looking to roll this out.

Thanks!

@ewbankkit ewbankkit requested a review from a team as a code owner July 15, 2024 18:25
@ewbankkit ewbankkit self-assigned this Jul 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSCluster_configuration\|TestAccECSCluster_managedStorageConfiguration\|TestAccECSCluster_basic' PKG=ecs             
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSCluster_configuration\|TestAccECSCluster_managedStorageConfiguration\|TestAccECSCluster_basic -timeout 360m
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== RUN   TestAccECSCluster_managedStorageConfiguration
=== PAUSE TestAccECSCluster_managedStorageConfiguration
=== CONT  TestAccECSCluster_basic
=== CONT  TestAccECSCluster_managedStorageConfiguration
=== CONT  TestAccECSCluster_configuration
--- PASS: TestAccECSCluster_basic (22.23s)
--- PASS: TestAccECSCluster_configuration (41.65s)
--- PASS: TestAccECSCluster_managedStorageConfiguration (55.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	60.309s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 60f558e into hashicorp:main Jul 15, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 15, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_ecs_cluster-add_managed_storage_config branch July 20, 2024 19:07
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow assigning KMS keys for ECS Fargate ephemeral storage encryption
4 participants