Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_set_ids attribute to fms policy #38161

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Jun 27, 2024

Description

Add resource_set_ids attribute to fms policy

Relations

Closes #33372

References

Output from Acceptance Testing

> make testacc TESTARGS="-run=TestAccFMS_serial/Policy/rscSet" PKG=fms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fms/... -v -count 1 -parallel 20  -run=TestAccFMS_serial/Policy/rscSet -timeout 360m
=== RUN   TestAccFMS_serial
=== PAUSE TestAccFMS_serial
=== CONT  TestAccFMS_serial
=== RUN   TestAccFMS_serial/Policy
=== RUN   TestAccFMS_serial/Policy/rscSet
--- PASS: TestAccFMS_serial (1110.98s)
    --- PASS: TestAccFMS_serial/Policy (1110.98s)
        --- PASS: TestAccFMS_serial/Policy/rscSet (1110.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        1116.454s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fms Issues and PRs that pertain to the fms service. labels Jun 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 27, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 1, 2024
@nam054 nam054 marked this pull request as ready for review July 1, 2024 01:52
@nam054 nam054 requested a review from a team as a code owner July 1, 2024 01:52
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccFMS_serial/Policy/rscSet\|TestAccFMS_serial/Policy/basic' PKG=fms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/fms/... -v -count 1 -parallel 20  -run=TestAccFMS_serial/Policy/rscSet\|TestAccFMS_serial/Policy/basic -timeout 360m
=== RUN   TestAccFMS_serial
=== PAUSE TestAccFMS_serial
=== CONT  TestAccFMS_serial
=== RUN   TestAccFMS_serial/Policy
=== RUN   TestAccFMS_serial/Policy/basic
=== RUN   TestAccFMS_serial/Policy/rscSet
--- PASS: TestAccFMS_serial (3575.25s)
    --- PASS: TestAccFMS_serial/Policy (3575.25s)
        --- PASS: TestAccFMS_serial/Policy/basic (1292.65s)
        --- PASS: TestAccFMS_serial/Policy/rscSet (2282.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	3579.786s

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 11, 2024
@nam054 nam054 merged commit 1c1d430 into main Jul 11, 2024
40 checks passed
@nam054 nam054 deleted the f/add-resource-sets-to-policy branch July 11, 2024 16:43
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add resource_sets to aws_fms_policy
2 participants