Elb awssdkv2 migration

[mattburgess]

Description

Relations

Closes #36157

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[mattburgess]

tags_gen.go is failing to compile as the TagKeyOnly is in the types package, not the service package.
Generation of service_endpoints_gen_test.go needs some attention too.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELB' PKG=elb ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/elb/... -v -count 1 -parallel 3  -run=TestAccELB -timeout 360m
=== RUN   TestAccELBAppCookieStickinessPolicy_basic
=== PAUSE TestAccELBAppCookieStickinessPolicy_basic
=== RUN   TestAccELBAppCookieStickinessPolicy_disappears
=== PAUSE TestAccELBAppCookieStickinessPolicy_disappears
=== RUN   TestAccELBAppCookieStickinessPolicy_Disappears_elb
=== PAUSE TestAccELBAppCookieStickinessPolicy_Disappears_elb
=== RUN   TestAccELBAttachment_basic
=== PAUSE TestAccELBAttachment_basic
=== RUN   TestAccELBAttachment_disappears
=== PAUSE TestAccELBAttachment_disappears
=== RUN   TestAccELBBackendServerPolicy_basic
=== PAUSE TestAccELBBackendServerPolicy_basic
=== RUN   TestAccELBBackendServerPolicy_disappears
=== PAUSE TestAccELBBackendServerPolicy_disappears
=== RUN   TestAccELBBackendServerPolicy_update
=== PAUSE TestAccELBBackendServerPolicy_update
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== RUN   TestAccELBCookieStickinessPolicy_basic
=== PAUSE TestAccELBCookieStickinessPolicy_basic
=== RUN   TestAccELBCookieStickinessPolicy_disappears
=== PAUSE TestAccELBCookieStickinessPolicy_disappears
=== RUN   TestAccELBCookieStickinessPolicy_Disappears_elb
=== PAUSE TestAccELBCookieStickinessPolicy_Disappears_elb
=== RUN   TestAccELBSSLNegotiationPolicy_basic
=== PAUSE TestAccELBSSLNegotiationPolicy_basic
=== RUN   TestAccELBSSLNegotiationPolicy_update
=== PAUSE TestAccELBSSLNegotiationPolicy_update
=== RUN   TestAccELBSSLNegotiationPolicy_disappears
=== PAUSE TestAccELBSSLNegotiationPolicy_disappears
=== RUN   TestAccELBListenerPolicy_basic
=== PAUSE TestAccELBListenerPolicy_basic
=== RUN   TestAccELBListenerPolicy_update
=== PAUSE TestAccELBListenerPolicy_update
=== RUN   TestAccELBListenerPolicy_disappears
=== PAUSE TestAccELBListenerPolicy_disappears
=== RUN   TestAccELBLoadBalancerDataSource_basic
=== PAUSE TestAccELBLoadBalancerDataSource_basic
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== RUN   TestAccELBLoadBalancer_disappears
=== PAUSE TestAccELBLoadBalancer_disappears
=== RUN   TestAccELBLoadBalancer_nameGenerated
=== PAUSE TestAccELBLoadBalancer_nameGenerated
=== RUN   TestAccELBLoadBalancer_namePrefix
=== PAUSE TestAccELBLoadBalancer_namePrefix
=== RUN   TestAccELBLoadBalancer_tags
=== PAUSE TestAccELBLoadBalancer_tags
=== RUN   TestAccELBLoadBalancer_fullCharacterRange
=== PAUSE TestAccELBLoadBalancer_fullCharacterRange
=== RUN   TestAccELBLoadBalancer_AccessLogs_enabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_enabled
=== RUN   TestAccELBLoadBalancer_AccessLogs_disabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_disabled
=== RUN   TestAccELBLoadBalancer_generatesNameForZeroValue
=== PAUSE TestAccELBLoadBalancer_generatesNameForZeroValue
=== RUN   TestAccELBLoadBalancer_availabilityZones
=== PAUSE TestAccELBLoadBalancer_availabilityZones
=== RUN   TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
=== PAUSE TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
=== RUN   TestAccELBLoadBalancer_Swap_subnets
=== PAUSE TestAccELBLoadBalancer_Swap_subnets
=== RUN   TestAccELBLoadBalancer_instanceAttaching
=== PAUSE TestAccELBLoadBalancer_instanceAttaching
=== RUN   TestAccELBLoadBalancer_listener
=== PAUSE TestAccELBLoadBalancer_listener
=== RUN   TestAccELBLoadBalancer_healthCheck
=== PAUSE TestAccELBLoadBalancer_healthCheck
=== RUN   TestAccELBLoadBalancer_timeout
=== PAUSE TestAccELBLoadBalancer_timeout
=== RUN   TestAccELBLoadBalancer_connectionDraining
=== PAUSE TestAccELBLoadBalancer_connectionDraining
=== RUN   TestAccELBLoadBalancer_securityGroups
=== PAUSE TestAccELBLoadBalancer_securityGroups
=== RUN   TestAccELBLoadBalancer_desyncMitigationMode
=== PAUSE TestAccELBLoadBalancer_desyncMitigationMode
=== RUN   TestAccELBLoadBalancer_desyncMitigationMode_update
=== PAUSE TestAccELBLoadBalancer_desyncMitigationMode_update
=== RUN   TestAccELBPolicy_basic
=== PAUSE TestAccELBPolicy_basic
=== RUN   TestAccELBPolicy_disappears
=== PAUSE TestAccELBPolicy_disappears
=== RUN   TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly
=== PAUSE TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly
=== RUN   TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly
=== PAUSE TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly
=== RUN   TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy
=== PAUSE TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy
=== RUN   TestAccELBPolicy_SSLSecurityPolicy_predefined
=== PAUSE TestAccELBPolicy_SSLSecurityPolicy_predefined
=== RUN   TestAccELBPolicy_updateWhileAssigned
=== PAUSE TestAccELBPolicy_updateWhileAssigned
=== RUN   TestAccELBProxyProtocolPolicy_basic
=== PAUSE TestAccELBProxyProtocolPolicy_basic
=== RUN   TestAccELBServiceAccountDataSource_basic
=== PAUSE TestAccELBServiceAccountDataSource_basic
=== RUN   TestAccELBServiceAccountDataSource_region
=== PAUSE TestAccELBServiceAccountDataSource_region
=== CONT  TestAccELBAppCookieStickinessPolicy_basic
=== CONT  TestAccELBLoadBalancer_AccessLogs_enabled
=== CONT  TestAccELBSSLNegotiationPolicy_update
--- PASS: TestAccELBAppCookieStickinessPolicy_basic (32.39s)
=== CONT  TestAccELBLoadBalancer_basic
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (44.29s)
=== CONT  TestAccELBLoadBalancer_fullCharacterRange
--- PASS: TestAccELBLoadBalancer_basic (20.63s)
=== CONT  TestAccELBLoadBalancer_tags
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (21.61s)
=== CONT  TestAccELBLoadBalancer_namePrefix
--- PASS: TestAccELBLoadBalancer_namePrefix (20.08s)
=== CONT  TestAccELBLoadBalancer_nameGenerated
--- PASS: TestAccELBLoadBalancer_tags (39.47s)
=== CONT  TestAccELBLoadBalancer_disappears
--- PASS: TestAccELBLoadBalancer_nameGenerated (21.45s)
=== CONT  TestAccELBBackendServerPolicy_update
--- PASS: TestAccELBLoadBalancer_disappears (16.67s)
=== CONT  TestAccELBSSLNegotiationPolicy_basic
--- PASS: TestAccELBSSLNegotiationPolicy_basic (26.17s)
=== CONT  TestAccELBCookieStickinessPolicy_Disappears_elb
--- PASS: TestAccELBCookieStickinessPolicy_Disappears_elb (19.01s)
=== CONT  TestAccELBCookieStickinessPolicy_disappears
--- PASS: TestAccELBCookieStickinessPolicy_disappears (23.85s)
=== CONT  TestAccELBCookieStickinessPolicy_basic
--- PASS: TestAccELBCookieStickinessPolicy_basic (30.62s)
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (9.85s)
=== CONT  TestAccELBLoadBalancer_desyncMitigationMode
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode (20.31s)
=== CONT  TestAccELBServiceAccountDataSource_region
--- PASS: TestAccELBServiceAccountDataSource_region (5.67s)
=== CONT  TestAccELBServiceAccountDataSource_basic
--- PASS: TestAccELBServiceAccountDataSource_basic (5.59s)
=== CONT  TestAccELBProxyProtocolPolicy_basic
--- PASS: TestAccELBProxyProtocolPolicy_basic (26.61s)
=== CONT  TestAccELBPolicy_updateWhileAssigned
--- PASS: TestAccELBPolicy_updateWhileAssigned (30.34s)
=== CONT  TestAccELBPolicy_SSLSecurityPolicy_predefined
--- PASS: TestAccELBPolicy_SSLSecurityPolicy_predefined (29.90s)
=== CONT  TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy (31.67s)
=== CONT  TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly (20.00s)
=== CONT  TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly
--- PASS: TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly (20.96s))
=== CONT  TestAccELBPolicy_disappears
--- PASS: TestAccELBPolicy_disappears (19.30s)
=== CONT  TestAccELBPolicy_basic
--- PASS: TestAccELBPolicy_basic (18.92s)
=== CONT  TestAccELBLoadBalancer_desyncMitigationMode_update
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode_update (43.41s)
=== CONT  TestAccELBListenerPolicy_basic
--- PASS: TestAccELBListenerPolicy_basic (18.91s)
=== CONT  TestAccELBListenerPolicy_update
--- PASS: TestAccELBSSLNegotiationPolicy_update (44.04s)
=== CONT  TestAccELBLoadBalancerDataSource_basic
--- PASS: TestAccELBLoadBalancerDataSource_basic (35.97s)
=== CONT  TestAccELBListenerPolicy_disappears
--- PASS: TestAccELBListenerPolicy_disappears (19.16s)
=== CONT  TestAccELBSSLNegotiationPolicy_disappears
--- PASS: TestAccELBBackendServerPolicy_update (37.47s)
=== CONT  TestAccELBLoadBalancer_instanceAttaching
--- PASS: TestAccELBLoadBalancer_instanceAttaching (149.41s)
=== CONT  TestAccELBLoadBalancer_securityGroups
--- PASS: TestAccELBLoadBalancer_securityGroups (32.55s)
=== CONT  TestAccELBLoadBalancer_availabilityZones
--- PASS: TestAccELBLoadBalancer_availabilityZones (28.08s)
=== CONT  TestAccELBLoadBalancer_connectionDraining
--- PASS: TestAccELBListenerPolicy_update (47.12s)
=== CONT  TestAccELBLoadBalancer_timeout
--- PASS: TestAccELBLoadBalancer_connectionDraining (37.34s)
=== CONT  TestAccELBLoadBalancer_healthCheck
--- PASS: TestAccELBLoadBalancer_timeout (25.13s)
=== CONT  TestAccELBLoadBalancer_listener
--- PASS: TestAccELBLoadBalancer_healthCheck (27.14s)
=== CONT  TestAccELBLoadBalancer_generatesNameForZeroValue
--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (20.39s)
=== CONT  TestAccELBAttachment_disappears
--- PASS: TestAccELBLoadBalancer_listener (69.11s)
=== CONT  TestAccELBBackendServerPolicy_disappears
--- PASS: TestAccELBAttachment_disappears (129.47s)
=== CONT  TestAccELBBackendServerPolicy_basic
--- PASS: TestAccELBSSLNegotiationPolicy_disappears (30.00s)
=== CONT  TestAccELBAppCookieStickinessPolicy_Disappears_elb
--- PASS: TestAccELBAppCookieStickinessPolicy_Disappears_elb (20.44s)
=== CONT  TestAccELBAttachment_basic
--- PASS: TestAccELBBackendServerPolicy_disappears (28.60s)
=== CONT  TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (68.52s)
=== CONT  TestAccELBAppCookieStickinessPolicy_disappears
--- PASS: TestAccELBAppCookieStickinessPolicy_disappears (20.59s)
=== CONT  TestAccELBLoadBalancer_AccessLogs_disabled
--- PASS: TestAccELBBackendServerPolicy_basic (64.15s)
=== CONT  TestAccELBLoadBalancer_Swap_subnets
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (44.68s)
--- PASS: TestAccELBAttachment_basic (505.10s)
--- PASS: TestAccELBLoadBalancer_Swap_subnets (67.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	2472.821s

[ewbankkit]

@mattburgess Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.