Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch/jobdef: Add image_pull_secret #38517

Merged
merged 11 commits into from
Jul 24, 2024
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 24, 2024

Description

Relations

Closes #38520

References

Output from Acceptance Testing

% make t T='TestAccBatchJobDefinition_EKSProperties_imagePullSecrets|TestAccBatchJobDefinition_basic|TestAccBatchJobDefinition_EKSProperties_basic' K=batch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_EKSProperties_imagePullSecrets|TestAccBatchJobDefinition_basic|TestAccBatchJobDefinition_EKSProperties_basic'  -timeout 360m
=== RUN   TestAccBatchJobDefinition_basic
=== PAUSE TestAccBatchJobDefinition_basic
=== RUN   TestAccBatchJobDefinition_EKSProperties_basic
=== PAUSE TestAccBatchJobDefinition_EKSProperties_basic
=== RUN   TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== PAUSE TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== CONT  TestAccBatchJobDefinition_basic
=== CONT  TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== CONT  TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (18.82s)
--- PASS: TestAccBatchJobDefinition_basic (18.86s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (18.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	21.455s

@YakDriver YakDriver requested a review from a team as a code owner July 24, 2024 17:01
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR. labels Jul 24, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 24, 2024
@ewbankkit ewbankkit self-assigned this Jul 24, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBatchJobDefinition_EKSProperties\|TestAccBatchJobDefinition_basic' PKG=batch ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/batch/... -v -count 1 -parallel 3  -run=TestAccBatchJobDefinition_EKSProperties\|TestAccBatchJobDefinition_basic -timeout 360m
=== RUN   TestAccBatchJobDefinition_basic
=== PAUSE TestAccBatchJobDefinition_basic
=== RUN   TestAccBatchJobDefinition_EKSProperties_basic
=== PAUSE TestAccBatchJobDefinition_EKSProperties_basic
=== RUN   TestAccBatchJobDefinition_EKSProperties_update
=== PAUSE TestAccBatchJobDefinition_EKSProperties_update
=== RUN   TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== PAUSE TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
=== CONT  TestAccBatchJobDefinition_basic
=== CONT  TestAccBatchJobDefinition_EKSProperties_update
=== CONT  TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (13.01s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_basic (13.51s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (21.62s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (11.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	29.345s

@YakDriver YakDriver merged commit 5d798ec into main Jul 24, 2024
48 checks passed
@YakDriver YakDriver deleted the f-batch-job-def-img-pull-secret branch July 24, 2024 21:59
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 24, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add eks_properties.*.pod_properties.*.image_pull_secret argument
2 participants