Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for additional Batch EKS Pod Properties #38606

Open
danquack opened this issue Jul 30, 2024 · 3 comments
Open

[Enhancement]: Add support for additional Batch EKS Pod Properties #38606

danquack opened this issue Jul 30, 2024 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.

Comments

@danquack
Copy link
Contributor

danquack commented Jul 30, 2024

Description

Some additional attributes were added to eksProperties:

  • initContainers
  • shareProcessNamespace

Affected Resource(s) and/or Data Source(s)

aws_batch_job_definition

Potential Terraform Configuration

resource "aws_batch_job_definition" "test" {
  name = "tf_test_batch_job_definition_eks"
  type = "container"
  eks_properties {
    pod_properties {
      host_network = true
      init_containers {
        image = "public.ecr.aws/amazonlinux/amazonlinux:1"
        command = [
          "sleep",
          "60"
        ]
        resources {
          limits = {
            cpu    = "1"
            memory = "1024Mi"
          }
        }
      }
      // More properties removed
    }
  }
}

References

https://docs.aws.amazon.com/batch/latest/APIReference/API_EksPodProperties.html

Would you like to implement a fix?

Yes

@danquack danquack added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 30, 2024
@github-actions github-actions bot added the service/batch Issues and PRs that pertain to the batch service. label Jul 30, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 30, 2024
@danquack danquack changed the title [Enhancement]: Add support for additional EKS Pod Properties [Enhancement]: Add support for additional Batch EKS Pod Properties Jul 30, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 31, 2024
@justinretzolk
Copy link
Member

Hey @danquack 👋 Heads up: unless I'm misunderstanding, looks like image_pull_secret, at least, was included in 5.60.0 via #38517.

@danquack
Copy link
Contributor Author

Good catch @justinretzolk. Missed that in the schema scroll. I'll remove that pull secret, but the other ones still needs attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Development

No branches or pull requests

2 participants