Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_chatbot_teams_channel_configuration: New resource #38630

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 31, 2024

Description

Relations

Closes #12304
Relates #38124

References

Output from Acceptance Testing

We are currently unable to fully test this resource and ask for community with testing.

% make t T=TestAccChatbotTeamsChannelConfiguration_serial K=chatbot
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/chatbot/... -v -count 1 -parallel 20 -run='TestAccChatbotTeamsChannelConfiguration_serial'  -timeout 360m
=== RUN   TestAccChatbotTeamsChannelConfiguration_serial
=== PAUSE TestAccChatbotTeamsChannelConfiguration_serial
=== CONT  TestAccChatbotTeamsChannelConfiguration_serial
=== RUN   TestAccChatbotTeamsChannelConfiguration_serial/basic
    teams_channel_configuration_test.go:52: Environment variable CHATBOT_TEAMS_TEAM_ID is not set, skipping test
=== RUN   TestAccChatbotTeamsChannelConfiguration_serial/disappears
    teams_channel_configuration_test.go:97: Environment variable CHATBOT_TEAMS_TEAM_ID is not set, skipping test
--- PASS: TestAccChatbotTeamsChannelConfiguration_serial (0.00s)
    --- SKIP: TestAccChatbotTeamsChannelConfiguration_serial/basic (0.00s)
    --- SKIP: TestAccChatbotTeamsChannelConfiguration_serial/disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chatbot	2.766s

@YakDriver YakDriver requested a review from a team as a code owner July 31, 2024 21:50
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/chatbot Issues and PRs that pertain to the chatbot service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jul 31, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. labels Jul 31, 2024
@YakDriver YakDriver changed the title aws_chatbot_team_channel_configuration: New resource aws_chatbot_teams_channel_configuration: New resource Aug 1, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit 870c6cf into main Aug 1, 2024
69 checks passed
@YakDriver YakDriver deleted the f-chatbot-microsoft-teams-configuration branch August 1, 2024 17:53
@github-actions github-actions bot added this to the v5.61.0 milestone Aug 1, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 1, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chatbot Issues and PRs that pertain to the chatbot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Chatbot
3 participants