[TechDebt]: Reduce use of errs.Must

[jar-b]

Description

errs.Must is overused within the internal/services sub-packages, most often wrapping calls to the flex.FlattenResourceId function.

% rg "errs.Must\(flex.FlattenResourceId" --count | wc -l
37

These errors should be explicitly handled and returned via a diagnostic rather than causing the provider to panic.

References

• Relates [Bug]: When applying an aws_cloudformation_stack_set_instance, i got an error: panic: unexpected format for ID parts ([<stackset_name> <stack_set_instance>]), the following id parts indexes are blank ([1]) #38846

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.