Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add encryption_type and kms_key_id params to aws_kenesis_stream data source #39212

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Sep 8, 2024

Description

This PR is to add two new attributes, encryption_type and kms_key_id, to the aws_kenesis_stream data source.

Relations

Closes #38791

References

Referred to StreamDescriptionSummary for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccKinesisStreamDataSource_ PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStreamDataSource_'  -timeout 360m
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN   TestAccKinesisStreamDataSource_encryption
=== PAUSE TestAccKinesisStreamDataSource_encryption
=== CONT  TestAccKinesisStreamDataSource_basic
=== CONT  TestAccKinesisStreamDataSource_encryption
--- PASS: TestAccKinesisStreamDataSource_encryption (66.18s)
--- PASS: TestAccKinesisStreamDataSource_basic (102.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    103.254s

$

@acwwat acwwat requested a review from a team as a code owner September 8, 2024 07:09
Copy link

github-actions bot commented Sep 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kinesis Issues and PRs that pertain to the kinesis service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Sep 8, 2024
@acwwat acwwat force-pushed the f-aws_kenesis_stream-add_encryption_params branch from 7bac59e to 2a6448b Compare September 8, 2024 07:10
@acwwat acwwat force-pushed the f-aws_kenesis_stream-add_encryption_params branch from 2a6448b to 2960873 Compare September 8, 2024 16:49
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2024
@ewbankkit ewbankkit self-assigned this Sep 11, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKinesisStreamDataSource_' PKG=kinesis ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/kinesis/... -v -count 1 -parallel 3  -run=TestAccKinesisStreamDataSource_ -timeout 360m
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN   TestAccKinesisStreamDataSource_encryption
=== PAUSE TestAccKinesisStreamDataSource_encryption
=== CONT  TestAccKinesisStreamDataSource_basic
=== CONT  TestAccKinesisStreamDataSource_encryption
--- PASS: TestAccKinesisStreamDataSource_encryption (60.35s)
--- PASS: TestAccKinesisStreamDataSource_basic (93.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	98.806s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2ac898f into hashicorp:main Sep 11, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 11, 2024
@GuillaumeDesforges
Copy link

Thank you very much for this improvement 🎉

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_kenesis_stream-add_encryption_params branch September 16, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/kinesis Issues and PRs that pertain to the kinesis service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: add attribute kms_key_id to data aws_kinesis_stream
3 participants