[Bug]: TestAccBatchJobQueue_MigrateFromPluginSDK failing on v5.66.0

[t0yv0]

Terraform Core Version

1.8.3

AWS Provider Version

5.66.0

Affected Resource(s)

• aws_batch_job_queue

Expected Behavior

Migrating aws_batch_job_queue instances from V0 schema (SDKv2) to the current schema is no longer working. This is evidenced by the following failing acceptance test:

TF_ACC=1 go test -run TestAccBatchJobQueue_MigrateFromPluginSDK -test.v                                                          ~/code/terraform-provider-aws/internal/service/batch
=== RUN   TestAccBatchJobQueue_MigrateFromPluginSDK
=== PAUSE TestAccBatchJobQueue_MigrateFromPluginSDK
=== CONT  TestAccBatchJobQueue_MigrateFromPluginSDK
    job_queue_test.go:160: Step 2/2 error: Error running pre-apply plan: exit status 1
        
        Error: Value Conversion Error
        
          with aws_batch_job_queue.test,
          on terraform_plugin_test.tf line 110, in resource "aws_batch_job_queue" "test":
         110: resource "aws_batch_job_queue" "test" {
        
        An unexpected error was encountered trying to convert into a Terraform value.
        This is always an error in the provider. Please report the following to the
        provider developer:
        
        Cannot use attr.Value basetypes.MapValue, only tags.Map is supported because
        tags.mapType is the type in the schema
    panic.go:629: Error retrieving state, there may be dangling resources: exit status 1
        Failed to marshal state to json: schema version 0 for aws_batch_job_queue.test in state does not match version 1 from the provider
--- FAIL: TestAccBatchJobQueue_MigrateFromPluginSDK (49.14s)

Note that the test passes on 5.65.0 version of the provider.

It seems to be related to tags handling and I suspect one of these commits triggered the issue, though I have not taken the time to root cause it.

commit 5d81c01bb1a6481f021b82df1e2ec46d747bbee6
Author: Graham Davison <gdavison@hashicorp.com>
Date:   Mon Aug 12 15:13:24 2024 -0700

    Uses `tags.MapValue` for `tags_all`

commit 2b4ac7036179b159f35889d6df623e58c831cc2f
Author: Graham Davison <gdavison@hashicorp.com>
Date:   Mon Aug 12 14:16:13 2024 -0700

    Supports `null` valued tags in Framework. Implements in `batch`

commit b401ff780a19957d164fbb673582af695c85269f
Author: Graham Davison <gdavison@hashicorp.com>
Date:   Mon Aug 12 16:09:36 2024 -0700

    Adds Semgrep check for type of Tags and TagsAll fields

Actual Behavior

See failing test above.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

See failing acc test above.

Steps to Reproduce

See failing acc test above.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[t0yv0]

Looks like this duplicates #39257 which already is fixed on latest, good news.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.