Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/vpc_endpoint- refactor to use keyvaluetags #11730

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688
Release note for CHANGELOG:

None

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSVpcEndpoint_'
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (89.15s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (167.35s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (148.46s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (90.80s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (502.10s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (400.81s)
--- PASS: TestAccAWSVpcEndpoint_removed (76.59s)

@DrFaust92 DrFaust92 requested a review from a team January 23, 2020 08:46
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 23, 2020
@bflad bflad self-assigned this Feb 5, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2020
@bflad bflad added this to the v2.48.0 milestone Feb 5, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSVpcEndpoint_removed (20.86s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (26.64s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (28.15s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (41.70s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (44.93s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (50.58s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (247.20s)
--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (255.35s)
--- PASS: TestAccAWSVpcEndpointService_basic (264.18s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (268.65s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (274.74s)
--- PASS: TestAccAWSVpcEndpointService_removed (276.38s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (294.34s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (364.63s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (655.93s)

@bflad bflad merged commit eced99f into hashicorp:master Feb 5, 2020
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the vpc-endpoint-tags branch March 15, 2020 07:48
@ghost
Copy link

ghost commented Mar 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants