Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsByTopic and return immediately on errors #14262

Merged
merged 2 commits into from
Jul 24, 2020

Commits on Jul 21, 2020

  1. tests/resource/aws_sns_topic_subscription: Fix recurring and unrelate…

    …d test configuration error
    
    Previously:
    
    ```
    --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (63.28s)
    testing.go:684: Step 0 error: After applying this step, the plan was not empty:
    DIFF:
    UPDATE: aws_api_gateway_authorizer.test
    ...
    authorizer_result_ttl_in_seconds: "300" => "0"
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s)
    ```
    bflad committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    0b32ef9 View commit details
    Browse the repository at this point in the history
  2. resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsB…

    …yTopic and return immediately on errors
    
    Reference: #13409
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSNSTopicSubscription_basic (13.47s)
    --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (27.13s)
    --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (28.12s)
    --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (28.38s)
    --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (48.31s)
    --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s)
    ```
    bflad committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    28ff18e View commit details
    Browse the repository at this point in the history