resource/cloudfront_distribution: re-introduce changes from #10013 to update active_trusted_signers attribute #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute for Terraform 0.12 Reference: #8902 This attribute implemented a legacy Terraform library (`flatmap`), which does not work with Terraform 0.12's data types and whose only usage was on this single attribute. This was missed during the Terraform 0.12 upgrade since there were no covering acceptance tests and the CloudFront setup itself is fairly esoteric (requires root AWS account login to manage CloudFront Keys). The attribute now correctly implements (in the closest approximation) the standard Terraform Provider SDK types and methodology for saved nested object data to the Terraform state. The `items` subattribute list is now accessible again in Terraform 0.12. It does, however, unavoidably switch the root `active_trusted_signers` attribute to `TypeList` instead of `TypeMap` (which does not support map elements of different types in the current Terraform Provider SDK), so any potential references to nested attributes will need to be changed in user configurations, e.g. Previously: ``` aws_cloudfront_distribution.example.active_trusted_signers.enabled ``` Now: ``` aws_cloudfront_distribution.example.active_trusted_signers.0.enabled ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (611.33s) ``` (cherry picked from commit ebdc976)
…fixes (cherry picked from commit cad90e6)
…ctive_trusted_signers", ...) error Output from acceptance testing: ``` --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners ``` (cherry picked from commit 1c2b6f4)
ghost
added
size/M
anGie44
changed the title
|
Does Terraform 0.12 not have the state reading issue after upgrade? We originally pulled this out (#10093) because it appeared to require a state migration due the SDK difference handlers, even for configurations not using the actual attribute. An easier option to state migration (especially because the schema is huge for this resource), would be to remove the broken attribute and introduce a new one. |
|
Ready for re-review with re-named sub-field Output of tests: |
ghost
added
size/XL
anGie44
force-pushed
the
td-cloudfront-distribution-flatmap
branch
from
4faef14
to
d452680
Compare
…form-providers/terraform-provider-aws into td-cloudfront-distribution-flatmap
bflad
approved these changes
Jul 29, 2020
|
Output of acceptance tests: |
anGie44
added a commit
that referenced
this pull request
Jul 29, 2020
|
This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #8902
Release note for CHANGELOG:
Output from acceptance testing: