Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ec2_transit_gateway_route: cidr match is unreliable #14846

Merged
merged 5 commits into from
Oct 9, 2020
Merged

aws_ec2_transit_gateway_route: cidr match is unreliable #14846

merged 5 commits into from
Oct 9, 2020

Commits on Aug 25, 2020

  1. aws_ec2_transit_gateway_route: ipv6 support 

    * aws api returns expanded prefix, but hcl may contain compressed prefix
* use cidrBlocksEqual() instead of string comparison to find route
* normalize route destination value to RFC1924 compressed
    @kblackham-hv
    kblackham-hv committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    2fee2a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. use canonicalCidrBlock() from hashicorp#14543

    @kblackham-hv
    kblackham-hv committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    bd0020b View commit details
    Browse the repository at this point in the history

  2. use aws.String() instead of string pointer 

    Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
    @thekev @ewbankkit
    thekev and ewbankkit committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a47f75e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Renames some validator tests 

    They were causing the full set of acceptance tests to run if `validators_test.go` is modified
    @gdavison
    gdavison committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    c054cfc View commit details
    Browse the repository at this point in the history

  2. Adds some test cases to TestCanonicalCidrBlock

    @gdavison
    gdavison committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    fdc29cf View commit details
    Browse the repository at this point in the history