Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_query_log_config_association: New resource #14901

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 28, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #14877
Additive to #14897.

Release note for CHANGELOG:

New resource `aws_route53_resolver_query_log_config_association`.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:48: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (41.47s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (44.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.994s

@ewbankkit ewbankkit requested a review from a team August 28, 2020 21:35
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 28, 2020
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 29, 2020
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

small question, is it possible to add a disappears test for the parent resource to association resource test ? i from experience thats its sometimes possible.

--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (88.43s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (77.02s)

@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Aug 30, 2020
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Aug 30, 2020

An aws_route53_resolver_query_log_config can't be deleted if it has active aws_route53_resolver_query_log_config_associations which is why the Route53ResolverQueryLogConfig sweeper depends on the Route53ResolverQueryLogConfigAssociation sweeper running first.

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 21, 2020
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit !

Verified Acceptance Tests (Commercial)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:100: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (33.32s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (38.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.027s

Verified Acceptance Tests (GovCloud)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:100: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (31.96s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (33.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.275s

@breathingdust breathingdust merged commit 2f81e85 into hashicorp:master Sep 21, 2020
breathingdust added a commit that referenced this pull request Sep 21, 2020
@ewbankkit ewbankkit deleted the f-aws_route53_resolver_query_log_config_association-resource branch September 21, 2020 16:06
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants