-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/service/rds: Remove hardcoded instance classes from EC2-Classic tests and basic data source test #15184
Conversation
… tests and basic data source test Reference: #15182 Previously: ``` === CONT TestAccAWSDBInstance_ec2Classic TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2248: Step 1/1 error: terraform failed: exit status 1 stderr: Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time. status code: 400, request id: 5bc39058-0571-4f63-bb80-c25533285646 --- FAIL: TestAccAWSDBInstance_ec2Classic (5.31s) === CONT TestAccAWSDbInstanceDataSource_ec2Classic TestAccAWSDbInstanceDataSource_ec2Classic: data_source_aws_db_instance_test.go:51: Step 1/1 error: terraform failed: exit status 1 stderr: Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time. status code: 400, request id: 38414095-00df-4a5d-ba25-241b5c400ef6 --- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (15.24s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSDbInstanceDataSource_basic (617.92s) --- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (456.35s) --- PASS: TestAccAWSDBInstance_ec2Classic (406.18s) ```
The output from acceptance testing on GovCloud (failures are unrelated to this change, see #14778):
Commercial (failures are unrelated or flaky):
|
Yeah sorry, this was intentionally only to fix the two consistent |
I was just waiting for TC. Looks good! |
This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #15182
Release note for CHANGELOG:
Previously:
Output from acceptance testing: