Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Add TimestreamWrite service client (#15421) #15451

Merged
merged 2 commits into from
Oct 2, 2020
Merged

provider: Add TimestreamWrite service client (#15421) #15451

merged 2 commits into from
Oct 2, 2020

Conversation

yardensachs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15421

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@yardensachs yardensachs requested a review from a team October 2, 2020 14:29
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 2, 2020
@yardensachs yardensachs changed the title provider: Add Macie2 service client (#15421) provider: Add TimestreamWrite service client (#15421) Oct 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2020
@yardensachs
Copy link
Contributor Author

This PR is 1 out of 2 PRs, split from #15444 per @DrFaust92 request

@yardensachs yardensachs force-pushed the f-timestreamwrite-service-client branch from 5ed2159 to 7dbf7f7 Compare October 2, 2020 15:20
@github-actions
Copy link

github-actions bot commented Oct 2, 2020

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by Renovate Bot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via Renovate Bot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via Renovate Bot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@yardensachs
Copy link
Contributor Author

yardensachs commented Oct 2, 2020 •
edited
Loading

I am actually not sure what to do, if I remove mod/sum the tests fail. What is the best way to move forward?

@ewbankkit
Copy link
Contributor

@yardensachs A maintainer must merge #15226 first to pull in the latest AWS SDK.

@yardensachs yardensachs force-pushed the f-timestreamwrite-service-client branch from a0c22a0 to 7dbf7f7 Compare October 2, 2020 16:13
@bflad
Copy link
Contributor

bflad commented Oct 2, 2020

Updated AWS Go SDK dependency has been merged, so this should be happier when rebased. 👍

bflad
bflad approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good once rebased. 🚀

website/allowed-subcategories.txt Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Oct 2, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2020
@bflad bflad added this to the v3.10.0 milestone Oct 2, 2020
yardensachs and others added 2 commits October 2, 2020 12:50
@yardensachs yardensachs force-pushed the f-timestreamwrite-service-client branch from ee2410d to a1ad94f Compare October 2, 2020 19:50
@bflad bflad merged commit 0b201d9 into hashicorp:master Oct 2, 2020
@yardensachs
Copy link
Contributor Author

asd

@yardensachs yardensachs mentioned this pull request Oct 2, 2020
Merged
@yardensachs yardensachs deleted the f-timestreamwrite-service-client branch October 2, 2020 21:04
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yardensachs @ewbankkit @bflad