Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ECS Service Capacity Provider Updates #16402

Closed
wants to merge 1 commit into from
Closed

Allow ECS Service Capacity Provider Updates #16402

wants to merge 1 commit into from

Conversation

m13t
Copy link

@m13t m13t commented Nov 24, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11351

Release note for CHANGELOG:

resource/aws_ecs_service: Allow updating existing capacity providers without destroying service

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. labels Nov 24, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 24, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @m13t 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Base automatically changed from master to main January 23, 2021 00:59
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 27, 2021
@ewbankkit
Copy link
Contributor

@m13t Thanks for the contribution 👏.
There is already a further along PR that addresses the issue - #16942 - so I am going to close this one.

@ewbankkit ewbankkit closed this May 27, 2021
@m13t
Copy link
Author

m13t commented May 27, 2021

@ewbankkit thanks for the update. I did notice the other issue wasn't raised until Jan but this was opened in November and raise with our enterprise support team but we didn't seem to get any engagement. Anything we can do to avoid this again in the future where solutions are posed and missed?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating ECS service capacity provider strategy replaces resource
3 participants