Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/ds/region: Fix hardcoded region #16523

Merged
merged 1 commit into from
Dec 2, 2020
Merged

tests/ds/region: Fix hardcoded region #16523

merged 1 commit into from
Dec 2, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 2, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995 Phase 2

Release note for CHANGELOG:

NONE

Affected tests:

'TestFindRegionByName|TestFindRegionByEc2Endpoint'

Output from acceptance testing (GovCloud):

--- PASS: TestFindRegionByEc2Endpoint (0.00s)
--- PASS: TestFindRegionByName (0.00s)

Output from acceptance testing (commercial):

--- PASS: TestFindRegionByEc2Endpoint (0.00s)
--- PASS: TestFindRegionByName (0.00s)

@YakDriver YakDriver requested a review from a team as a code owner December 2, 2020 01:44
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Dec 2, 2020
@YakDriver YakDriver mentioned this pull request Dec 2, 2020
Closed
@bflad bflad self-assigned this Dec 2, 2020
bflad
bflad approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@YakDriver YakDriver added this to the v3.20.0 milestone Dec 2, 2020
@YakDriver YakDriver merged commit 33eebc5 into master Dec 2, 2020
@YakDriver YakDriver deleted the t-gov-hardregion-region branch December 2, 2020 15:16
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad