Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increased max retention period for kinesis stream to 8760 #16608

Merged
merged 2 commits into from
Dec 22, 2020
Merged

increased max retention period for kinesis stream to 8760 #16608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
086e4e0
increased max retention period for kinesis stream to 8760
with-joy Dec 5, 2020
f05b945
update documentation
with-joy Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws/resource_aws_kinesis_stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func resourceAwsKinesisStream() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Default: 24,
ValidateFunc: validation.IntBetween(24, 168),
ValidateFunc: validation.IntBetween(24, 8760),
},

"shard_level_metrics": {
Expand Down
4 changes: 2 additions & 2 deletions aws/resource_aws_kinesis_stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func TestAccAWSKinesisStream_retentionPeriod(t *testing.T) {
testAccCheckKinesisStreamExists(resourceName, &stream),
testAccCheckAWSKinesisStreamAttributes(&stream),
resource.TestCheckResourceAttr(
resourceName, "retention_period", "100"),
resourceName, "retention_period", "8760"),
),
},

Expand Down Expand Up @@ -663,7 +663,7 @@ func testAccKinesisStreamConfigUpdateRetentionPeriod(rInt int) string {
resource "aws_kinesis_stream" "test" {
name = "terraform-kinesis-test-%d"
shard_count = 2
retention_period = 100
retention_period = 8760

tags = {
Name = "tf-test"
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/kinesis_stream.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The following arguments are supported:
* `name` - (Required) A name to identify the stream. This is unique to the AWS account and region the Stream is created in.
* `shard_count` – (Required) The number of shards that the stream will use.
Amazon has guidelines for specifying the Stream size that should be referenced when creating a Kinesis stream. See [Amazon Kinesis Streams][2] for more.
* `retention_period` - (Optional) Length of time data records are accessible after they are added to the stream. The maximum value of a stream's retention period is 168 hours. Minimum value is 24. Default is 24.
* `retention_period` - (Optional) Length of time data records are accessible after they are added to the stream. The maximum value of a stream's retention period is 8760 hours. Minimum value is 24. Default is 24.
* `shard_level_metrics` - (Optional) A list of shard-level CloudWatch metrics which can be enabled for the stream. See [Monitoring with CloudWatch][3] for more. Note that the value ALL should not be used; instead you should provide an explicit list of metrics you wish to enable.
* `enforce_consumer_deletion` - (Optional) A boolean that indicates all registered consumers should be deregistered from the stream so that the stream can be destroyed without error. The default value is `false`.
* `encryption_type` - (Optional) The encryption type to use. The only acceptable values are `NONE` or `KMS`. The default value is `NONE`.
Expand Down