Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_codebuild_project: Deprecate source and secondary_sources auth blocks #17465

Merged
merged 2 commits into from
Mar 17, 2021
Merged

resource/aws_codebuild_project: Deprecate source and secondary_sources auth blocks #17465

merged 2 commits into from
Mar 17, 2021

Commits on Mar 17, 2021

  1. resource/aws_codebuild_project: Deprecate source and secondary_source… 

    …s auth blocks

Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html
Reference: #13450

Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing:

```
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s)
    testing.go:683: Step 1 error: errors during apply:

        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
```

The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the `aws_codebuild_source_credential` resource and removing the problematic test rather than temporarily introducing a skipping mechanism.
    @bflad
    bflad committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    f726bee View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #17465

    @bflad
    bflad committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    cbdc721 View commit details
    Browse the repository at this point in the history